Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Anchor-428] Add refund memo to platform transaction #1091

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Sep 5, 2023

Description

Add missing refund memo to the platform trasaction

Context

Testing

Known limitations

N/A

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1091.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1091.previews.kube001.services.stellar-ops.com/

@JakeUrban
Copy link
Contributor

Can we add some tests that verify they're present where they should be?

@Ifropc
Copy link
Contributor Author

Ifropc commented Sep 5, 2023

I don't think we have a test for GetTransaction at the moment

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Code Coverage

Overall Project 28.47% -0.01%
Files changed 53.85%

Module Coverage
core 72.85% 🍏
api-schema 1.79% -0.02%
Files
Module File Coverage
core TransactionHelper.java 63.09% 🍏
api-schema PlatformTransactionData.java 0% -0.94%

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr1091.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr1091.previews.kube001.services.stellar-ops.com/

@Ifropc Ifropc merged commit 4aa31af into develop Sep 5, 2023
6 checks passed
@Ifropc Ifropc deleted the ANCHOR-428-refunds branch September 5, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants