Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-363] Implement SEP-6 transaction store #981

Merged

Conversation

philipliu
Copy link
Contributor

@philipliu philipliu commented Jul 10, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

This implements the SEP-6 transaction store. Specifically, it includes the JdbcSep6Transaction POJO as well as the migration file to create the table in the platform database.

Why

This is required for the /deposit and /withdraw implementations coming up.

Known limitations

N/A

@stellar-jenkins

This comment was marked as outdated.

@philipliu philipliu force-pushed the feature/anchor-363-transaction-store branch from edde361 to 9f6091c Compare July 10, 2023 20:29
@stellar-jenkins

This comment was marked as duplicate.

@stellar-jenkins

This comment was marked as duplicate.

@philipliu philipliu changed the title [ANCHOR-363] Implement Sep6Transaction [ANCHOR-363] Implement SEP-6 transaction store Jul 10, 2023
@stellar-jenkins

This comment was marked as duplicate.

@stellar-jenkins

This comment was marked as duplicate.

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr981.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr981.previews.kube001.services.stellar-ops.com/

@philipliu philipliu marked this pull request as ready for review July 11, 2023 15:44
Copy link
Collaborator

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stellar-jenkins
Copy link

Reference Server Preview is available here:
https://anchor-ref-pr981.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr981.previews.kube001.services.stellar-ops.com/

@philipliu philipliu merged commit 0e0c02a into stellar:develop Jul 13, 2023
5 checks passed
@philipliu philipliu deleted the feature/anchor-363-transaction-store branch July 13, 2023 19:52
JiahuiWho pushed a commit to JiahuiWho/java-stellar-anchor-sdk that referenced this pull request Jul 17, 2023
* Implement Sep6Transaction

* Add migration file

* DI

* Cleanup

* Cleanup more

* Add a TODO

* Fix build
JiahuiWho added a commit that referenced this pull request Jul 18, 2023
)

* wip

* Make tests to pass

Fix the potential Java reference server not properly shutdown

Fix the Spring configuration binding and tests

Add run event processing server config

First working version

Add some unit tests

removed unused code

Change the event processing server port to 8088

* Clean up unused code

* anchor-244-Implement the webhook callback in the event processor

* [ANCHOR-363] Implement SEP-6 transaction store (#981)

* Implement Sep6Transaction

* Add migration file

* DI

* Cleanup

* Cleanup more

* Add a TODO

* Fix build

---------

Co-authored-by: Jamie Li <[email protected]>
Co-authored-by: Philip Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants