Add support for Preview 10 operations when assembling Soroban transactions. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
commented
Jul 10, 2023
| const invokeOp: Operation.InvokeHostFunction = raw.operations[0]; | ||
| txnBuilder.addOperation( | ||
| Operation.invokeHostFunction({ | ||
| source: invokeOp.source, |
There was a problem hiding this comment.
note that previously we weren't copying the source
sreuland
reviewed
Jul 10, 2023
src/transaction.ts
Outdated
|
|
||
| case "bumpFootprintExpiration": | ||
| const bumpOp: Operation.BumpFootprintExpiration = raw.operations[0]; | ||
| txnBuilder.addOperation( |
There was a problem hiding this comment.
since this and restore case are not merging any data from simulation, can it reduce to txnBuilder.addOperation(raw.operations[0]), or I may be missing a subtlety.
There was a problem hiding this comment.
I thought so, too, but kept getting some TypeScript errors... tried it again in ea8ccb3 and it worked 🤦 Great call, thank you!
sreuland
approved these changes
Jul 10, 2023
Shaptic
added a commit
that referenced
this pull request
Jul 11, 2023
Shaptic
added a commit
that referenced
this pull request
Jul 11, 2023
* Add test case for #108 * Upgrade all dependencies to their latest minor versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #107 to allow
BumpFootprintExpirationOps andRestoreFootprintOps to be assembled when users callsimulateTransactionandprepareTransaction.