Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stable Protocol 20 release (both XDR and RPC schemas) #886

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Dec 1, 2023

This prepares a stable Protocol 20 release with support for the latest XDR and RPC schemas, including:

This should mirror stellar/js-soroban-client#167.

For reviewers: The best way to review this, imo, is to compare it directly to the changes that were made in soroban-client to the stable branch. Specifically, this diff covers everything needed for the latest stable version.

@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Dec 1, 2023
@Shaptic Shaptic self-assigned this Dec 1, 2023
Copy link

socket-security bot commented Dec 1, 2023

Copy link

github-actions bot commented Dec 1, 2023

Size Change: -329 kB (-3%)

Total Size: 11.7 MB

Filename Size Change
dist/stellar-sdk.js 6.73 MB -235 kB (-3%)
dist/stellar-sdk.min.js 5.01 MB -93.4 kB (-2%)

compressed-size-action

@@ -146,7 +146,7 @@
"bignumber.js": "^9.1.2",
"eventsource": "^2.0.2",
"randombytes": "^2.1.0",
"stellar-base": "10.0.0-beta.4",
"stellar-base": "git+https://github.com/stellar/js-stellar-base#master",
Copy link

@sreuland sreuland Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this pr wait on stellar-base to release first, and pin this to 10.0.0 here, or you anticipate doing another release prep pr with that bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge because this won't be released, and then have a separate PR to update to the stable git ref and bump to the stable version. This will make it easier to isolate the changes that need to be reviewed! And we can use master as the gitref for E2E tests. Wdyt?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that works, could also git ref to the pr for e2e concerns, so whichever process is preferred, I just was curious on the pinning aspect there, thanks!

Copy link

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one comment on the stellar-base ref.

@Shaptic Shaptic merged commit f3228f6 into master Dec 6, 2023
7 of 8 checks passed
@Shaptic Shaptic deleted the stable branch December 6, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants