Replace CRA with Webpack + Node 18 #320
Conversation
|
Something went wrong with PR preview build please check |
1 similar comment
|
Something went wrong with PR preview build please check |
|
Something went wrong with PR preview build please check |
|
Preview is available here: |
| "vendor-wallets": { | ||
| test: /[\\/]node_modules[\\/](@albedo|@ledgerhq|trezor)[\\/]/, | ||
| name: "vendor-wallets", | ||
| chunks: "all", |
There was a problem hiding this comment.
I like this organization of node_modules! From the docs, my assumption this is a way to make sure we don't duplicate any of these libs (thus reducing bloat). Is that what your aim is here? Curious if there are any other benefits I'm missing
There was a problem hiding this comment.
If I remember correctly this is to make the generated file smaller by adding these only once. It was initially done in the Account Viewer in this PR. Looks like it was a lot of trial and error to get it right. 😅
No description provided.