Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use home domain for SEP-10 auth + don't show duplicate logs #324

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix: use home domain for SEP-10 auth + don't show duplicate logs #324

merged 2 commits into from
Sep 19, 2023

Conversation

quietbits
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

Preview is available here:
http://stellar-demo-wallet-client-pr324.previews.kube001.services.stellar-ops.com/

JakeUrban
JakeUrban reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcelosalloum
marcelosalloum approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've tested with the home domain sdp-backend-pr46.previews.kube001.services.stellar-ops.com and got the following SEP10 signed challenge transaction, which is correct ✅:

AAAAAgAAAABjQeyWPXZhYZrbcFOqhWz4F85moGTn5oI3KlYaszcc2AAAASwAAAAAAAAAAAAAAAEAAAAAZQjgyAAAAABlCORMAAAAAAAAAAMAAAABAAAAAKeckE9ikv1QIkS7cnzB/coEWVixy8msUD+SQxPGhEOoAAAACgAAAD9zZHAtYmFja2VuZC1wcjQ2LnByZXZpZXdzLmt1YmUwMDEuc2VydmljZXMuc3RlbGxhci1vcHMuY29tIGF1dGgAAAAAAQAAAEB0ZGVZdWNvTjhTVEEzcloxTkpPbUtWdVliT0tmYjNwelZIYW5HVUhjWWhTK21NL2VXR1IrRHc2ZHNpZFJNRzJZAAAAAQAAAABjQeyWPXZhYZrbcFOqhWz4F85moGTn5oI3KlYaszcc2AAAAAoAAAAPd2ViX2F1dGhfZG9tYWluAAAAAAEAAAA1c2RwLWFwLXByNDYucHJldmlld3Mua3ViZTAwMS5zZXJ2aWNlcy5zdGVsbGFyLW9wcy5jb20AAAAAAAABAAAAAFnd4Z0VECI6ZsbbqiVrzyF2iABqGhas8mzJRYYbORrqAAAACgAAAA1jbGllbnRfZG9tYWluAAAAAAAAAQAAAD9kZW1vLXdhbGxldC1zcnYtcHIzMjQucHJldmlld3Mua3ViZTAwMS5zZXJ2aWNlcy5zdGVsbGFyLW9wcy5jb20AAAAAAAAAAAOzNxzYAAAAQHl6k7q85pKZ07mJOlwexBSVzCymbA9orBt6FnpfQ/eWqpa2kvPbrBJCRqyvTlGLj9Od5zEdanHhMpCrhAqCiA8bORrqAAAAQFza1CQ4PNX+zTLBbK058ov1uXZoromFnMa/EraGBeZkc0k9MLb7mR8zNrjjtP/4QT37mPbkE36qhWS2S2KEtQDGhEOoAAAAQL/zQxN/H9oHiGwOusl/CKmXK0Srlvqlu5G+WQtVlCCeixQzV+acjHZHBVoCZziax1dbtfXjNxHS2OyTqYIqDAI=

@quietbits quietbits merged commit 16a925b into master Sep 19, 2023
2 checks passed
@quietbits quietbits deleted the fix-sep-home-domain-for-sep10 branch September 19, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeUrban JakeUrban JakeUrban left review comments

@marcelosalloum marcelosalloum marcelosalloum approved these changes

@Ifropc Ifropc Ifropc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@quietbits @stellar-jenkins @marcelosalloum @JakeUrban @Ifropc