SDP-1116 Support External_ID DRAFT PR (See TODO). reece #256

reecexlm · 2024-04-12T18:58:14Z

What

This change will be deployed in a branch with a PR Preview pipeline to support Vibrant Assist in testing integration of supporting external_id in SDP registration deep link and sep24 post interactive deposit for partner integration.

The receiver’s invitation DeepLink should include the field external_id, containing the ID of that receiver_wallet

This code will not be merged for now. We should decide if we want to adopt this external-id field or not.

TBH, it could remove the need for an OTP step on our end, but we should discuss if we want that.

We need to validate the decision with @nando Vieira before concluding if this will be part of the official implementation, or if an optional field.

added some additional unit tests and verified all existing tests are passing.

Why

To support reconciliation of vibrant client (mobile phone) with SDP Host Customer ID by using an external_id field in the deeplink sent from the sdp host (SDP registration deep link). then this will be passed within SEP24 claims for reconciliation.

Known limitations / TODO

TBD - not yet part of this PR: When validating the wallet-registration, verify if the SEP24 incoming info contains the field: customer_id=external_id:hash(phone_number) Use the external_id to find the user in our database Hash the user’s phone number and compare it with the incoming hashed phone number It’s ok to send an informative response, so Vibrant can understand this well.

PR Structure

[x ] This PR has a reasonably narrow scope
[x ] This PR title and description are clear enough for anyone to review it.
This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

This PR adds tests for the new functionality or fixes.
This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

there is a new configuration option useExternalID (true/false) to make this optional. This has not yet been updated to helm charts yet until we determine if we plan to include this support in our standard release.

Release

not for release at this time. only for testing with Vibrant.

Deployment

Will be deployed only in a pr-preview pipeline at this time.

stellar-jenkins · 2024-04-12T18:59:19Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

marcelosalloum

This is looking pretty good, congrats!

I've shared some thoughts below on:

some connection points that are missing (to make things easier for you)
my opinion on where to do the final verification when validating the user in the SEP24 request.

Also, a nitpicky thing: indentation is looking a bit weird in some places. It looks like the old problem of spaces vs tabs indentation.

internal/data/assets_test.go

marcelosalloum · 2024-04-12T19:12:03Z

internal/serve/serve.go

You will need to propagate the UseExternalID config to the handler responsible for /wallet-registration/verification, injecting it in:

stellar-disbursement-platform-backend/internal/serve/serve.go

Lines 435 to 441 in 977e0c3

r.With(sep24HeaderTokenAuthenticationMiddleware).Post("/verification", httphandler.VerifyReceiverRegistrationHandler{

AnchorPlatformAPIService: o.AnchorPlatformAPIService,

Models: o.Models,

ReCAPTCHAValidator: reCAPTCHAValidator,

NetworkPassphrase: o.NetworkPassphrase,

EventProducer: o.EventProducer,

}.VerifyReceiverRegistration)

internal/serve/httphandler/verifiy_receiver_registration_handler.go

cmd/serve.go

stellar-jenkins · 2024-04-16T18:56:18Z

Something went wrong with PR preview build please check

stellar-jenkins · 2024-04-16T19:06:22Z

Something went wrong with PR preview build please check

stellar-jenkins · 2024-04-16T19:51:11Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-18T18:47:35Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-18T23:18:36Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-04-19T14:49:48Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-05-01T20:01:33Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-05-09T20:44:25Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

dev/scripts/sep24_deposit.go

+	// Create a client to skip certificate verification (for testing)
+	client := &http.Client{
+		Transport: &http.Transport{
+			TLSClientConfig: &tls.Config{InsecureSkipVerify: true},


stellar-jenkins · 2024-05-09T20:53:01Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-05-09T20:58:30Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-05-09T23:01:54Z

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr256.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr256.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr256.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-05-31T05:19:34Z

Something went wrong with PR preview build please check

stellar-jenkins · 2024-07-20T20:34:33Z

Something went wrong with PR preview build please check

initial without sep24 claim verification

d6adff0

reecexlm requested a review from marcelosalloum April 12, 2024 18:58

marcelosalloum reviewed Apr 12, 2024

View reviewed changes

resolve conflicts

2b7aa01

reecexlm had a problem deploying to Receiver Registration - E2E Integration Tests April 16, 2024 18:55 — with GitHub Actions Failure

reecexlm had a problem deploying to Anchor Integration Tests April 16, 2024 18:55 — with GitHub Actions Failure

missed resolving 2 conflicts

6b24019

reecexlm had a problem deploying to Anchor Integration Tests April 16, 2024 19:05 — with GitHub Actions Failure

reecexlm had a problem deploying to Receiver Registration - E2E Integration Tests April 16, 2024 19:05 — with GitHub Actions Failure

updates to serveopts for multitenancy to support external-id

66b017d

reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests April 16, 2024 19:50 — with GitHub Actions Inactive

reecexlm temporarily deployed to Anchor Integration Tests April 16, 2024 19:50 — with GitHub Actions Inactive

fix for tenant domain in unit test

99bb3c9

reecexlm temporarily deployed to Anchor Integration Tests April 18, 2024 18:46 — with GitHub Actions Inactive

reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests April 18, 2024 18:46 — with GitHub Actions Inactive

draft of customer-id/hashed mobile# verification

ee87c8b

reecexlm temporarily deployed to Anchor Integration Tests April 18, 2024 23:17 — with GitHub Actions Inactive

reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests April 18, 2024 23:17 — with GitHub Actions Inactive

adding more tests

88245da

marcelosalloum assigned reecexlm Apr 19, 2024

Fix indentation and tests.

b05dc79

marcelosalloum temporarily deployed to Receiver Registration - E2E Integration Tests April 19, 2024 14:48 — with GitHub Actions Inactive

marcelosalloum temporarily deployed to Anchor Integration Tests April 19, 2024 14:48 — with GitHub Actions Inactive

debugging

7d6c88e

reecexlm temporarily deployed to Anchor Integration Tests May 1, 2024 20:00 — with GitHub Actions Inactive

reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests May 1, 2024 20:00 — with GitHub Actions Inactive

put middleware tenant check back

9495335

reecexlm had a problem deploying to Anchor Integration Tests May 9, 2024 20:41 — with GitHub Actions Failure

reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests May 9, 2024 20:41 — with GitHub Actions Inactive

github-advanced-security bot found potential problems May 9, 2024

View reviewed changes

turn debug off

91844b6

reecexlm had a problem deploying to Anchor Integration Tests May 9, 2024 20:51 — with GitHub Actions Failure

reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests May 9, 2024 20:51 — with GitHub Actions Inactive

try moving health to top of handleHTTP

cbae53c

reecexlm had a problem deploying to Receiver Registration - E2E Integration Tests May 9, 2024 20:57 — with GitHub Actions Failure

reecexlm had a problem deploying to Anchor Integration Tests May 9, 2024 20:57 — with GitHub Actions Failure

only warn on tenant missing

0a0f0ef

reecexlm temporarily deployed to Receiver Registration - E2E Integration Tests May 9, 2024 23:01 — with GitHub Actions Inactive

reecexlm had a problem deploying to Anchor Integration Tests May 9, 2024 23:01 — with GitHub Actions Failure

Merge branch 'develop' into sdp-1116-externalid

a9c87f9

reecexlm had a problem deploying to Anchor Integration Tests May 31, 2024 05:18 — with GitHub Actions Failure

reecexlm had a problem deploying to Receiver Registration - E2E Integration Tests May 31, 2024 05:18 — with GitHub Actions Failure

Merge branch 'develop' into sdp-1116-externalid

3e6ef02

reecexlm had a problem deploying to Receiver Registration - E2E Integration Tests (Circle) July 20, 2024 20:33 — with GitHub Actions Failure

reecexlm had a problem deploying to Receiver Registration - E2E Integration Tests (Stellar) July 20, 2024 20:33 — with GitHub Actions Failure

reecexlm had a problem deploying to Anchor Integration Tests July 20, 2024 20:33 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDP-1116 Support External_ID DRAFT PR (See TODO). reece #256

SDP-1116 Support External_ID DRAFT PR (See TODO). reece #256

reecexlm commented Apr 12, 2024

stellar-jenkins commented Apr 12, 2024

marcelosalloum left a comment

marcelosalloum Apr 12, 2024

stellar-jenkins commented Apr 16, 2024

stellar-jenkins commented Apr 16, 2024

stellar-jenkins commented Apr 16, 2024

stellar-jenkins commented Apr 18, 2024

stellar-jenkins commented Apr 18, 2024

stellar-jenkins commented Apr 19, 2024

stellar-jenkins commented May 1, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 31, 2024

stellar-jenkins commented Jul 20, 2024

	r.With(sep24HeaderTokenAuthenticationMiddleware).Post("/verification", httphandler.VerifyReceiverRegistrationHandler{
	AnchorPlatformAPIService: o.AnchorPlatformAPIService,
	Models: o.Models,
	ReCAPTCHAValidator: reCAPTCHAValidator,
	NetworkPassphrase: o.NetworkPassphrase,
	EventProducer: o.EventProducer,
	}.VerifyReceiverRegistration)

SDP-1116 Support External_ID DRAFT PR (See TODO). reece #256

Are you sure you want to change the base?

SDP-1116 Support External_ID DRAFT PR (See TODO). reece #256

Conversation

reecexlm commented Apr 12, 2024

What

Why

Known limitations / TODO

PR Structure

Thoroughness

Configs and Secrets

Release

Deployment

stellar-jenkins commented Apr 12, 2024

marcelosalloum left a comment

Choose a reason for hiding this comment

marcelosalloum Apr 12, 2024

Choose a reason for hiding this comment

stellar-jenkins commented Apr 16, 2024

stellar-jenkins commented Apr 16, 2024

stellar-jenkins commented Apr 16, 2024

stellar-jenkins commented Apr 18, 2024

stellar-jenkins commented Apr 18, 2024

stellar-jenkins commented Apr 19, 2024

stellar-jenkins commented May 1, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 9, 2024

stellar-jenkins commented May 31, 2024

stellar-jenkins commented Jul 20, 2024