Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzing guide code block formatting #1224

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

leighmcculloch
Copy link
Member

What

Change the formatting of the code blocks on the fuzzing guide from 'shell' to nothing.

Why

Shell formatting shouldn't be used for simple commands, otherwise the formatter will highly random arguments that happen to fit shell keywords.

@leighmcculloch leighmcculloch marked this pull request as ready for review January 22, 2025 22:19
@stellar-jenkins
Copy link

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with you, the weird highlighting sometimes feels... well, weird lol.

The nit-picker in me likes to have something specified, so i typically use text as the "language" when i don't want any highlighting. but that just stems from this markdownlint plugin for vs code i use, and it flags that there "should always be a language specified." but, honestly, it's more of a preference thing hehe.

@leighmcculloch
Copy link
Member Author

I don't mind whether it is text or nothing. What should I do?

@leighmcculloch
Copy link
Member Author

I'll change it.

@leighmcculloch leighmcculloch merged commit d48f03c into main Jan 23, 2025
1 of 2 checks passed
@leighmcculloch leighmcculloch deleted the build-fuzzing-shell-fmt branch January 23, 2025 05:58
@stellar-jenkins
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants