Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Forms: Making radio options and submit button translatable #639

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

andrescifuentesr
Copy link
Contributor

  • Form - radio options do not show the translation, and the styling of the form is not being copied
  • Making submit button translatable

Initially reported here:
https://wpml.org/forums/topic/kadence-form-adv-block-not-translateable-2/

🎫 #[Jira Ticket]

...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

andrescifuentesr and others added 2 commits January 2, 2025 09:27
- Form - radio options do not show the translation, and the styling of the form is not being copied
- Making submit button translatable

Initially reported here:
https://wpml.org/forums/topic/kadence-form-adv-block-not-translateable-2/
@oakesjosh oakesjosh merged commit aa6e84a into stellarwp:master Jan 29, 2025
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants