Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been talking for a while now to move away from the
robot.http
implemention of the HTTP client. I did some more refactoring and we finally don't have to use it anymore. This means our bot is a bit cleaner.Main points:
http.js
-- which could be considered a breaking change from the previous packageRocketChatUploader.js
-- but I fear it has no tests, so I have no way of knowing if we're OKGrafanaClient
-- we droppedcreateHttpClient
and so better validation of the Grafana response.sendDashboardChartFromString
for convenience to theBot
(should be another PR, but makes testing easier for me).hbenl.vscode-mocha-test-adapter
test adapter. Now we don't have to do a.only
all the time, but just run the test from the IDE: