ADD: Release Fixes (#2097)

* FIX: beaconcha button directing to validator page * FIX: Valdiator Exit Process
stereum-dev · Oct 17, 2024 · 39ec976 · 39ec976
1 parent b877260
commit 39ec976
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/launcher/src/backend/Monitoring.js b/launcher/src/backend/Monitoring.js
@@ -3166,7 +3166,7 @@ rm -rf diskoutput
     }
 
     try {
-      const beaconAPIPort = beaconStatus.data[0].beacon.destinationPort;
+      const beaconAPIPort = beaconStatus.data[0].beacon.servicePort;
       const serviceId = beaconStatus.data[0].sid;
       if (!Array.isArray(pubkey)) {
         pubkey = [pubkey];
@@ -3177,7 +3177,7 @@ rm -rf diskoutput
         if (!output.includes("{") || !output.includes("}")) {
           return {
             pubkey: pubkey,
-            code: null,
+            code: /20[0-8] OK/.test(output) ? 200 : null,
             msg: output,
           };
         }
@@ -3223,6 +3223,8 @@ rm -rf diskoutput
           if (SSHService.checkExecError(runExitCommand) && runExitCommand.stderr) {
             throw new Error(SSHService.extractExecError(runExitCommand));
           }
+          if (!runExitCommand.stdout)
+            throw `ReturnCode: ${runExitCommand.rc}\nStderr: ${runExitCommand.stderr}\nStdout: ${runExitCommand.stdout}\nIs Your Consensus Client Running?`;
 
           const response = parseRunExitCommandOutput(runExitCommand.stdout, pubkey);
 

diff --git a/launcher/src/backend/ValidatorAccountManager.js b/launcher/src/backend/ValidatorAccountManager.js
@@ -225,6 +225,9 @@ export class ValidatorAccountManager {
 
       //Error handling
       if (SSHService.checkExecError(result) && result.stderr) throw SSHService.extractExecError(result);
+      if (!result.stdout)
+        throw `ReturnCode: ${result.rc}\nStderr: ${result.stderr}\nStdout: ${result.stdout}\nIs Your Consensus Client Running?`;
+
       const data = JSON.parse(result.stdout);
       if (data.data === undefined) {
         if (data.code === undefined || data.message === undefined) {
@@ -703,7 +706,18 @@ export class ValidatorAccountManager {
 
       this.nodeConnection.taskManager.otherTasksHandler(ref, `Get Remote Keys`, true, result.stdout);
 
+      //Error handling
+      if (SSHService.checkExecError(result) && result.stderr) throw SSHService.extractExecError(result);
+      if (!result.stdout)
+        throw `ReturnCode: ${result.rc}\nStderr: ${result.stderr}\nStdout: ${result.stdout}\nIs Your Consensus Client Running?`;
+
       const data = JSON.parse(result.stdout);
+      if (data.data === undefined) {
+        if (data.code === undefined || data.message === undefined) {
+          throw "Undexpected Error: " + result;
+        }
+        throw data.code + " " + data.message;
+      }
       if (!data.data) data.data = [];
 
       this.nodeConnection.taskManager.otherTasksHandler(ref);

diff --git a/launcher/src/components/UI/staking-page/components/list/rows/KeyRow.vue b/launcher/src/components/UI/staking-page/components/list/rows/KeyRow.vue
@@ -309,7 +309,7 @@ const navToBeaconcha = (network) => {
     holesky: "https://holesky.beaconcha.in/",
   };
 
-  const url = urls[network];
+  const url = urls[network] + "validator/" + props.item.key;
   if (url) {
     window.open(url, "_blank");
   } else {