Make sure const var variables are constant
#982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3daa298 ("Add support for `const` variables") added support for constant variables, but had a small mistake and did propagate the constant flag from the parser if the variable is declared with the `var` keyword. Still allowing to modify those variables. Fix this. Signed-off-by: Lars-Peter Clausen <[email protected]>
Check that variables declared with `const var` can not be modified. Signed-off-by: Lars-Peter Clausen <[email protected]>
larsclausen
changed the title
const var variables are constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3daa298 ("Add support for
constvariables") added support forconstant variables, but had a small mistake and did propagate the constant
flag from the parser if the variable is declared with the
varkeyword.Still allowing to modify those variables. Fix this.