Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the contacts examples slightly more standalone #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pinotree
Copy link
Contributor

Instead of symlinking the scripts directory in the grantlee sources to the source directory of this example, directly invoke the extract_strings_linguist.py script with its relative path for the example source directory.

The linguist_ts target still depends on something outside of it, however now it is possible to build the contacts example on its own, even when it is copied as standalone out of the grantlee sources.

@codecov-io
Copy link

codecov-io commented Dec 28, 2019

Codecov Report

Merging #61 (5e02f8f) into master (b27333e) will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   89.62%   89.06%   -0.57%     
==========================================
  Files         159      158       -1     
  Lines       11392    11275     -117     
==========================================
- Hits        10210    10042     -168     
- Misses       1182     1233      +51     
Impacted Files Coverage Δ
textdocument/lib/markupdirector_p.h 50.00% <0.00%> (-50.00%) ⬇️
textdocument/lib/abstractmarkupbuilder.h 50.00% <0.00%> (-50.00%) ⬇️
textdocument/lib/plaintextmarkupbuilder.cpp 53.89% <0.00%> (-16.17%) ⬇️
textdocument/lib/markupdirector.cpp 69.86% <0.00%> (-6.98%) ⬇️
templates/lib/outputstream.cpp 76.66% <0.00%> (-3.34%) ⬇️
textdocument/lib/texthtmlbuilder.cpp 49.11% <0.00%> (-0.89%) ⬇️
templates/defaulttags/ifchanged.cpp 91.07% <0.00%> (-0.16%) ⬇️
templates/tests/testbuiltins.cpp 99.46% <0.00%> (-0.04%) ⬇️
templates/tests/testdefaulttags.cpp 99.70% <0.00%> (-0.01%) ⬇️
templates/lib/metatype.cpp 100.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27333e...566bd66. Read the comment docs.

@pinotree
Copy link
Contributor Author

@steveire hi, can you please take a look at this PR? Thanks in advance

@steveire
Copy link
Owner

@pinotree Hi, sorry for the delay.

${CMAKE_SOURCE_DIR}/../../ doesn't seem very standalone to me. Perhaps a cmake variable for the path should be used instead if present?

What motivates this? Is it an attempt to (debian-)package grantlee examples separate to the binaries?

@pinotree
Copy link
Contributor Author

${CMAKE_SOURCE_DIR}/../../ doesn't seem very standalone to me. Perhaps a cmake variable for the path should be used instead if present?

Yes, I know that, and I explained the reason of the change in the commit message. ${CMAKE_SOURCE_DIR}/../../ is now used only for the linguist_ts target, which is not run by default. Hence, with this PR you can build the example as-is, as long as you don't manually invoke the linguist_ts target.

What motivates this? Is it an attempt to (debian-)package grantlee examples separate to the binaries?

Yes, we do ship the examples/ subdirectory as-is as part of the -dev package of grantlee.

@pinotree
Copy link
Contributor Author

@steveire ping?

@steveire
Copy link
Owner

@pinotree When I was last trying to do something about this I was looking for you on IRC or another chat server. I didn't find you. Do you use any?

Instead of symlinking the scripts directory in the grantlee sources to
the source directory of this example, directly invoke the
extract_strings_linguist.py script with its relative path for the
example source directory.

The linguist_ts target still depends on something outside of it, however
now it is possible to build the contacts example on its own, even when
it is copied as standalone out of the grantlee sources.
@pinotree pinotree force-pushed the example-standalone branch from 5e86bb5 to 580ab48 Compare May 28, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants