-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the contacts examples slightly more standalone #61
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 89.62% 89.06% -0.57%
==========================================
Files 159 158 -1
Lines 11392 11275 -117
==========================================
- Hits 10210 10042 -168
- Misses 1182 1233 +51
Continue to review full report at Codecov.
|
5e02f8f
to
261570e
Compare
261570e
to
566bd66
Compare
@steveire hi, can you please take a look at this PR? Thanks in advance |
@pinotree Hi, sorry for the delay.
What motivates this? Is it an attempt to (debian-)package grantlee examples separate to the binaries? |
Yes, I know that, and I explained the reason of the change in the commit message.
Yes, we do ship the |
566bd66
to
5e86bb5
Compare
@steveire ping? |
@pinotree When I was last trying to do something about this I was looking for you on IRC or another chat server. I didn't find you. Do you use any? |
Instead of symlinking the scripts directory in the grantlee sources to the source directory of this example, directly invoke the extract_strings_linguist.py script with its relative path for the example source directory. The linguist_ts target still depends on something outside of it, however now it is possible to build the contacts example on its own, even when it is copied as standalone out of the grantlee sources.
5e86bb5
to
580ab48
Compare
Instead of symlinking the scripts directory in the grantlee sources to the source directory of this example, directly invoke the
extract_strings_linguist.py
script with its relative path for the example source directory.The
linguist_ts
target still depends on something outside of it, however now it is possible to build the contacts example on its own, even when it is copied as standalone out of the grantlee sources.