-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gitignore #77
base: master
Are you sure you want to change the base?
Add .gitignore #77
Conversation
It was done for compile_commands.json cleanup in the first place. Other entries were copied from KDE/marble repo as well. See also: https://invent.kde.org/sdk/kdesrc-build/-/issues/86
@steveire ping |
Ping, @steveire. Are you OK? |
Classical open source project: 1400+ commits repo, and one dead maintainer. I do hope he's alright tho~ @kossebau do you happen to have a commit access? |
Yes, this is the beauty of open source, you can just grab his code and do whatever you like with it as long as allowed by it's license, so far the author doesn't have time for this anymore and only eventually he merges patches, there's a ongoing process to import it in KDE libs, I forked this as Cutelee which might the merged back to the eventual KDE libs import, you can also fork it, afaik no one else has commit access. |
Forks are always expensive because of multiple technical and social reasons. They are the last resort when nothing else is effective. Good to know it's being worked on, though. Unfortunately, it also means that I can't fully close the issue on invent until the patch is applied. |
Nope, this here on Github is all Stephen's domain. BTW, he is aware of the state, thus already two years proposed in December 2019 to include Grantlee into KDE Frameworks: https://marc.info/?l=kde-core-devel&m=157566819811019&w=2 |
@ratijas I have not added a I see your gitignore doesn't have entries like that. The |
Hi @steveire! Glad to see you in this thread. I believe most of you questions regarding the purpose and reasons for this change are already answered at the linked issue in the first post (which is basically the commit message). Boiling it down:
|
Yes, it sure does. As I wrote in the description, that's what an "average KDE project" marble has in their gitignore, so I assume it would be a sane starting point. |
It was done for compile_commands.json cleanup in the first place.
Other entries were copied from KDE/marble repo as well.
See also: https://invent.kde.org/sdk/kdesrc-build/-/issues/86