Skip to content

Commit

Permalink
fix image urls
Browse files Browse the repository at this point in the history
  • Loading branch information
schacon authored and steveklabnik committed Mar 8, 2024
1 parent 4dc2c20 commit 03955df
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/sharing-code/remotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Branch changes to push to origin:

And now our project is up on GitHub!

![new project on github](/images/github-create.png)
![new project on github](../images/github-create.png)

Now we can push our branch up to GitHub:

Expand All @@ -69,7 +69,7 @@ If you collaborate on a project, as commits land on the main branch, you'll want
to update your local copy of that branch. I'm going to make a change in the
GitHub UI:

![creating a commit on github](/images/github-commit.png)
![creating a commit on github](../images/github-commit.png)

All I did was update the `Cargo.toml` to remove some comments. If you're
following along, you can make any change you'd like.
Expand Down Expand Up @@ -156,7 +156,7 @@ any unique prefix works: `vmunwxsk` is just as much a unique prefix of

We can now make a pull request out of this:

![github showing us we have a branch with recent pushes](/images/new-branch.png)
![github showing us we have a branch with recent pushes](../images/new-branch.png)

If you'd like to view this PR, you can find it
[here](https://github.com/steveklabnik/jj-hello-world/pull/1), though by the
Expand Down
6 changes: 3 additions & 3 deletions src/sharing-code/updating-prs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Oh no! Someone has asked for changes to our pull request.

![a screenshot of me commenting on my github PR](/images/pr-feedback.png)
![a screenshot of me commenting on my github PR](../images/pr-feedback.png)

We have two ways of making our change, and it depends on what the project's
maintainers prefer. Due to the way that GitHub shows or minimizes comments on
Expand Down Expand Up @@ -73,7 +73,7 @@ Branch changes to push to origin:
Move branch push-vmunwxsksqvk from 9410db49f9ba to ad6b9b149f88
```

![a screenshot of github, showing the new commit below our review](/images/new-pr-commit.png)
![a screenshot of github, showing the new commit below our review](../images/new-pr-commit.png)

Since we added a commit, the review comment is still there, which is why people
like this workflow.
Expand Down Expand Up @@ -172,7 +172,7 @@ Branch changes to push to origin:

We can see that reflected on GitHub:

![a screenshot of github showing that our branch was force pushed](/images/force-push-pr.png)
![a screenshot of github showing that our branch was force pushed](../images/force-push-pr.png)

Only one commit, and it shows that our comment is on an outdated commit.

Expand Down

0 comments on commit 03955df

Please sign in to comment.