Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR solver #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions include/solvers/qr.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
#pragma once
#include <universal/blas/matrix.hpp>
#include <norms.hpp>

namespace sw
{
namespace hprblas
{
template <typename Scalar>
auto qr(const universal::blas::matrix<Scalar> &A,
universal::blas::matrix<Scalar> &Q,
universal::blas::matrix<Scalar> &R)
{
using size_type = typename universal::blas::matrix<Scalar>::size_type;
size_type n = num_rows(A), m = num_cols(A);
for (size_type i = 0; i < m; ++i)
{
universal::blas::matrix<Scalar> v = help(A, 0, n, q);

if (i > 0)
{
help(R, 0, i, i, i) = transpose(help(R, 0, n, 0, i)) * help(A, 0, n, i, i);
Copy link
Author

@shikharvashistha shikharvashistha Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function should change the value of R in place which is not achieved yet.

//Problem => function should change value of the given matrix
v = help(A, 0, n, i, i) - help(Q, 0, n, 0, i) * help(R, 0, i, i, i);
}
R(i, i) = frobenius_norm(v);
help(Q, 0, n, i, i) = v / R(i, i);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same is the case here.

}
return std::make_pair(Q, R);
}
template <typename Scalar>
auto qr(const universal::blas::matrix<Scalar> &A)
{
using size_type = typename universal::blas::matrix<Scalar>::size_type;
size_type m = num_cols(A), n = num_rows(A);
universal::blas::matrix<Scalar> Q(n, m), R(n, n);
qr(A, Q, R);
return std::make_pair(Q, R);
}
template <typename Scalar>
universal::blas::matrix<Scalar> help(const universal::blas::matrix<Scalar> &A, Scalar rb, Scalar re, Scalar cb, Scalar ce)
{
using size_type = typename universal::blas::matrix<Scalar>::size_type;
universal::blas::matrix<Scalar> B(re - rb + 1, ce - cb + 1);
size_type p = 1, q = 1;
for (size_type i = rb; i <= re; ++i)
{
for (size_type j = cb; j <= ce; ++j)
{
B(p, q) = A(i, j);
++q;
}
++p;
}
return B;
}

} // namespace hprblas
} // namespace sw