Enable parallelisation for Windows #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #68.
Previously the packages used
parallel::mclapply()for parallelisation but apparently this is does not work on Windows. As an immediate workaround parallelisation was disabled for Windows but this is a poor outcome.This PR updates parallelisation such that it keeps the "fork" approach for non-Windows systems and implements the "socket" approach for Windows. Reference: https://dept.stat.lsa.umich.edu/~jerrick/courses/stat701/notes/parallel.html
The PR also includes a small but important change to the Dockerfile which ensures that
webseq()is updated each time the container is built.