feat(security): Implement sandboxed code execution #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add firejail-based sandbox for secure code execution - Implement code validation and restricted imports/calls - Update runner to use sandboxed execution - Add security test suite - Fix arbitrary code execution vulnerability (Fixes stitionai#639) - Add proper security measures (Fixes stitionai#648) Security: - Restrict dangerous imports and function calls - Run code in isolated firejail sandbox - Add timeout limits - Prevent network access in sandbox - Add comprehensive security tests Co-Authored-By: Erkin Alp Güney <[email protected]>
- Add firejail requirement to README.md - Update ARCHITECTURE.md with security details Co-Authored-By: Erkin Alp Güney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Sandboxed Code Execution
This PR implements secure code execution using firejail sandbox to address security vulnerabilities in code execution.
Changes
Security Measures
Testing
✓ Comprehensive test suite in
tests/test_sandbox.py✓ Verified sandbox restrictions work as expected
✓ Tested security validations for dangerous imports
✓ Confirmed proper integration with runner system
Documentation
Link to Devin run: https://app.devin.ai/sessions/121045305ac0458bbdf2566092dbc1b2