Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix H563ZI clock config. #2506

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix H563ZI clock config. #2506

merged 1 commit into from
Sep 3, 2024

Conversation

dojyorin
Copy link
Contributor

@dojyorin dojyorin commented Aug 29, 2024 •
edited
Loading

Pull Request template

Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:

Summary

This PR fixes/implements the following bugs/features

  • ADC/DAC input clock is too high
  • LPUART clock is low
  • Optimize PLL ratio
  • There were no plans to change LPUART, but since it will be lower than current value when I fix ADC/DAC problem, I changed it as described in Incorrect clock settings for NUCLEO-H563ZI #2505.
  • By setting SRC / M = 2 N = 250 for PLL1/2/3 you can flexibly determine clock source frequency and easily calculate division P/Q/R.

e.g. Generic boards and NUCLEO-H563ZI are portable by simply changing value of PLLM.

CubeMX Screenshots
  • for H563ZI
    image

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

Code formatting

  • Ensure AStyle check is passed thanks CI

Closing issues

Fixes #2505

@dojyorin dojyorin changed the title Fix H563ZI clock config. (#3) Fix H563ZI clock config. Aug 29, 2024
@dojyorin dojyorin mentioned this pull request Aug 29, 2024
Merged
1 task
@fpistm fpistm self-requested a review September 2, 2024 08:44
@fpistm fpistm added the enhancement New feature or request label Sep 2, 2024
@fpistm fpistm added this to the 2.9.0 milestone Sep 2, 2024
fpistm
fpistm requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clock config is not correct.

variants/STM32H5xx/H563Z(G-I)T_H573ZIT/generic_clock.c Outdated Show resolved Hide resolved
variants/STM32H5xx/H563Z(G-I)T_H573ZIT/generic_clock.c Outdated Show resolved Hide resolved
@dojyorin @fpistm
fix(h5): H563ZI clock config
353538d 
Remove all HSI usage.
Fix ADC/DAC clock frequency (125MHz).

Signed-off-by: Kazuki Ota <[email protected]>
Co-Authored-by: Frederic Pillon <[email protected]>
@fpistm fpistm merged commit 56655f3 into stm32duino:main Sep 3, 2024
23 checks passed
fpistm added a commit to dojyorin/Arduino_Core_STM32 that referenced this pull request Sep 3, 2024
@fpistm
fix(h5): ADC/DAC clock config
1f17775 
Complement of stm32duino#2506

Signed-off-by: Kazuki Ota <[email protected]>
Co-Authored-by: Frederic Pillon <[email protected]>
fpistm added a commit that referenced this pull request Sep 3, 2024
@fpistm
fix(h5): ADC/DAC clock config
2aa4e44 
Complement of #2506

Signed-off-by: Kazuki Ota <[email protected]>
Co-Authored-by: Frederic Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
STM32 core based on ST HAL
Status: Done
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

Incorrect clock settings for NUCLEO-H563ZI
2 participants
@dojyorin @fpistm