add support for stm32F407IGHx #2649
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Hi @hlgzhx
Thanks for the PR anyway, it is not complete.
see my comments.
Moreover, please reference the mcu added in the README.md and add a default SystemClock_Config in the generic_clock.c.
See the Wiki for all steps:
https://github.com/stm32duino/Arduino_Core_STM32/wiki/Add-a-new-variant-%28board%29
| @@ -4865,6 +4865,15 @@ GenF4.menu.pnum.GENERIC_F407ZGTX.build.product_line=STM32F407xx | |||
| GenF4.menu.pnum.GENERIC_F407ZGTX.build.variant=STM32F4xx/F407Z(E-G)T_F417Z(E-G)T | |||
| GenF4.menu.pnum.GENERIC_F407ZGTX.debug.svd_file={runtime.tools.STM32_SVD.path}/svd/STM32F4xx/STM32F407.svd | |||
|
|
|||
| # Generic F407IGHx | |||
There was a problem hiding this comment.
When adding a generic variant all possible boards entries have to be added in boards.txt by alphabetical order.
It misses:
Generic F407IEHx
Generic F407IETx
Generic F407IGTx
Generic F417IEHx
Generic F417IGHx
Generic F417IETx
Generic F417IGTx
Comment on lines
+49
to
+50
| RAM (xrw) : ORIGIN = 0x20000000, LENGTH = 128K | ||
| FLASH (rx) : ORIGIN = 0x8000000, LENGTH = 1024K |
There was a problem hiding this comment.
Suggested change
| RAM (xrw) : ORIGIN = 0x20000000, LENGTH = 128K | |
| FLASH (rx) : ORIGIN = 0x8000000, LENGTH = 1024K | |
| RAM (xrw) : ORIGIN = 0x20000000, LENGTH = LD_MAX_DATA_SIZE | |
| FLASH (rx) : ORIGIN = 0x8000000 + LD_FLASH_OFFSET, LENGTH = LD_MAX_SIZE - LD_FLASH_OFFSET |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add support for Generic STM32F407IGHx boards by editing boards.txt and add variants/STM32F4xx/F407I(E-G)(H-T)_F417I(E-G)(H-T)/ldscript.ld
compile test is passed,my board is in school but school is closed.if you need further test on uploading,please wait me to get back to school after Chinese new year.
im glad to fix further issues on supporting stm32f407ighx boards