This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
Passing the additional_description from Freighter to UPS #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be able to pass the additional description value up to UPS (which we've received from Freighter & generated in GrailsWeb), which means we need to add an extra field that we were previously not passing up to UPS.
|
I'd like to see a test around this in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to pass the additional description value up to UPS (which we've received from Freighter & generated in GrailsWeb), which means we need to add an extra field that we were previously not passing up to UPS.
AdditionalDescription is the value that I have seen this referred to as within the UPS documentation, but it's not crazy clear. Also, this is different from the key mentioned in the comments of the Jira task, being "AdditionalComments", but I have not seen that term appear at all in the UPS documentation, and AdditionalDescription fits their pattern more (re: Description)