Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

DL-2832 Added Gemfile for activesupport 5.1 and allow activesupport 6 #11

Conversation

alexanderdavidpan
Copy link

@alexanderdavidpan alexanderdavidpan commented Oct 28, 2020

Purpose

activesupport is a toolkit of support libraries and Ruby core extensions extracted from the Rails framework.

Affected versions of this package are vulnerable to Deserialization of Untrusted Data via the MemCacheStore and RedisCacheStore. when untrusted user input is written to the cache store using the raw: true parameter, re-reading the result from the cache can evaluate the user input as a Marshalled object instead of plain text.

Freighter uses this gem and activesupport versioning has a vulnerability in its current version range.

JIRA

https://stockx-services.atlassian.net/browse/DL-2382

Changes:

  • Added Gemfile for activesupport 5.1 and allow activesupport 6

@alexanderdavidpan alexanderdavidpan self-assigned this Oct 28, 2020
@alexanderdavidpan
Copy link
Author

FWIW, we don't use travis but I added the gemfile and updated travis CI just for consistency. The real meat of this PR is upgrading activesupport versioning.

@alexanderdavidpan alexanderdavidpan changed the title Added Gemfile for activesupport 5.1 and allow activesupport 6 Dl-2832 Added Gemfile for activesupport 5.1 and allow activesupport 6 Oct 28, 2020
@alexanderdavidpan alexanderdavidpan changed the title Dl-2832 Added Gemfile for activesupport 5.1 and allow activesupport 6 DL-2832 Added Gemfile for activesupport 5.1 and allow activesupport 6 Oct 28, 2020
Copy link

@jrmullen jrmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexanderdavidpan alexanderdavidpan merged commit f9e1550 into master Oct 28, 2020
@alexanderdavidpan alexanderdavidpan deleted the add_gemfile_for_activesupport_51_and_allow_for_activesupport_6 branch October 28, 2020 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants