Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

(chore) Update testing suite and add CircleCI configuration #12

Merged
merged 6 commits into from
Nov 16, 2020
Merged

(chore) Update testing suite and add CircleCI configuration #12

merged 6 commits into from
Nov 16, 2020

Conversation

alexanderdavidpan
Copy link

@alexanderdavidpan alexanderdavidpan commented Oct 28, 2020 •
edited
Loading

Purpose

  • To update testing suite so future developers can push changes and run tests as part of CI.

Changes

  • Update mocha/mini_test lib reference to be valid.
  • Update nil assertions that will fail in later minitest version 6.
  • Use CGI.unescape vs deprecated URI.unescape method.
  • Update failing spec due to new fields added to Location model.
  • Add CircleCI config to run unit tests.

Testing

  • Run bundle exec rake test:unit - Specs pass ✅
  • Run bundle exec rake test:remote with local credentials -Specs pass ✅

@alexanderdavidpan alexanderdavidpan self-assigned this Oct 28, 2020
@alexanderdavidpan alexanderdavidpan changed the title (chore) Update testing suite (chore) Update testing suite and add CircleCI configuration Nov 16, 2020
ebachle
ebachle approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@ebachle ebachle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on the CI side!

jrmullen
jrmullen approved these changes Nov 16, 2020
View reviewed changes
Copy link

@jrmullen jrmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak much for the ruby, but the circleCI configuration looks ok to me 👍

@alexanderdavidpan alexanderdavidpan merged commit 92098f1 into master Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ebachle ebachle ebachle approved these changes

@jrmullen jrmullen jrmullen approved these changes

Assignees

@alexanderdavidpan alexanderdavidpan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderdavidpan @ebachle @jrmullen