This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
Revert ups.rb back to 6b5cfd5 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmercm
requested review from
ramin,
coty91,
muuule,
ktowner,
stephenjwinn,
grayxr,
mccurdyc,
brian31988,
wernermorgenstern,
Ryankoleanstockx and
lanestockx
wernermorgenstern
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for https://github.com/stockx/freighter/pull/122.
The issue with submitting
prepay = falseright now is we're guaranteed to be taking on the duties and taxes as the sender (DDP). There is aterms_of_shipment = 'DDP'flag that when set adds a duplicateShipmentChargeand causes a validation fail on UPS' end. The default here should be DDU (receiver will pay duties and taxes), theShipmentChargeshould only be added withterms_of_shipment = 'DDP'flag.