This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
Brian/bulk shipping #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmercm
reviewed
Jul 10, 2019
| @@ -631,6 +631,14 @@ def build_international_forms(xml, origin, destination, packages, options) | |||
| end | |||
| end | |||
|
|
|||
| def products(packages) | |||
| if packages && packages.first && packages.first.options && packages.first.options[:products] | |||
| packages.first.options[:products] | |||
There was a problem hiding this comment.
Is .first good enough or should we combine all products in all packages?
There was a problem hiding this comment.
@brian31988 ^^^ Was this comment resolved IRL? Is packages always an array with one element?
There was a problem hiding this comment.
Yea packages is always an array with one element
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stockx-services.atlassian.net/browse/BS-33
Pairs with https://github.com/stockx/freighter/pull/242