This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
LOC-12: Support character set label specification option #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custompro98
reviewed
Aug 19, 2019
| @@ -511,6 +511,8 @@ def build_shipment_request(origin, destination, packages, options={}) | |||
| label_format = options[:label_format] ? options[:label_format].upcase : 'GIF' | |||
| label_size = options[:label_size] ? options[:label_size] : [4, 6] | |||
|
|
|||
| character_set = options[:character_set] ? options[:character_set] : 'eng' | |||
There was a problem hiding this comment.
Not requesting the change, but a cool Ruby thing: options.fetch(:character_set, 'eng') will grab the value from the hash or return the 2nd arg as a default.
There was a problem hiding this comment.
And if you don't specify a 2nd arg to #fetch, it will raise an error rather than return nil if the key cannot be found.
custompro98
approved these changes
Aug 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: https://stockx-services.atlassian.net/browse/LOC-12
Specific card: https://stockx-services.atlassian.net/browse/LOC-201
Proposed Changes
Adds the character set option to the shipment request XML body
See pages 130-131 of the UPS Shipping Package XML Developer Guide for more information on the possible character set values.