Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

DL-17: Add processing fee and freight to the UPS commercial invoices #9

Merged
merged 9 commits into from
Jan 8, 2020

Conversation

jrmullen
Copy link

@jrmullen jrmullen commented Jan 7, 2020

Related Tickets

https://stockx-services.atlassian.net/browse/DL-17
Related Freighter PR: https://github.com/stockx/freighter/pull/314

Changes proposed

Add Shipping Fees and Processing Fees to the UPS commercial invoice

Expected Output

  • Shipping fees will appear under the 'Freight' line on the UPS commercial invoice
  • Processing fees will appear under the 'Other' line on the UPS commercial invoice

image-20200102-163209

New Routes

NA

Caveats

NA

Copy link

@otoplahcinski otoplahcinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

@grayxr grayxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, assuming this was tested?

@jrmullen jrmullen merged commit 44cd5e5 into master Jan 8, 2020
@jrmullen jrmullen deleted the mullen/DL-17 branch January 8, 2020 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants