Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.11 Manual Backport] Use the actual expiration date rather than a relative time in status #397

Merged

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Sep 26, 2024

The conflict was in test/e2e/case1_expiration_test.go.

Backport of:

@mprahl
Copy link
Contributor Author

mprahl commented Sep 26, 2024

/cherry-pick release-2.10

@openshift-cherrypick-robot

@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This also updates the status if the message changes.

Relates:
https://issues.redhat.com/browse/ACM-13736

Signed-off-by: mprahl <[email protected]>
Copy link

sonarcloud bot commented Sep 26, 2024

Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 91d196c into stolostron:release-2.11 Sep 30, 2024
13 checks passed
@openshift-cherrypick-robot

@mprahl: #397 failed to apply on top of branch "release-2.10":

Applying: Use the actual expiration date rather than a relative time in status
Using index info to reconstruct a base tree...
M	api/v1/certificatepolicy_types.go
M	deploy/crds/kustomize/policy.open-cluster-management.io_certificatepolicies.yaml
M	deploy/crds/policy.open-cluster-management.io_certificatepolicies.yaml
M	test/e2e/case1_expiration_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/case1_expiration_test.go
CONFLICT (content): Merge conflict in test/e2e/case1_expiration_test.go
Auto-merging deploy/crds/policy.open-cluster-management.io_certificatepolicies.yaml
CONFLICT (content): Merge conflict in deploy/crds/policy.open-cluster-management.io_certificatepolicies.yaml
Auto-merging deploy/crds/kustomize/policy.open-cluster-management.io_certificatepolicies.yaml
CONFLICT (content): Merge conflict in deploy/crds/kustomize/policy.open-cluster-management.io_certificatepolicies.yaml
Auto-merging api/v1/certificatepolicy_types.go
CONFLICT (content): Merge conflict in api/v1/certificatepolicy_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use the actual expiration date rather than a relative time in status
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants