Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uninstall.sh #164

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update uninstall.sh #164

wants to merge 8 commits into from

Conversation

Kyl-Bempah
Copy link
Contributor

PR made for https://github.com/open-cluster-management/backlog/issues/6177, need to finish editing script.

@TheRealHaoLiu
Copy link
Member

as part of the uninstall during canary i dont think we care about the rest of the manual cleanup

all we care is if mch is deleted successfully if mch delete hangs (with some timeout set) than we fail the testcase and move on

@TheRealHaoLiu
Copy link
Member

any forward movement with this PR?

nathanweatherly
nathanweatherly previously approved these changes Nov 3, 2020
@Kyl-Bempah
Copy link
Contributor Author

Uninstall script has been added, watch of mch status and supplemental code paths need to be added to canary & canary-scripts.

gurnben
gurnben previously approved these changes Nov 9, 2020
Copy link
Member

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM!

gurnben
gurnben previously approved these changes Nov 10, 2020
Copy link
Member

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, LGTM!

gurnben
gurnben previously approved these changes Nov 16, 2020
Copy link
Member

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, LGTM!

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kyl-Bempah
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kyl-Bempah
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +75 to +87
if [[ "$DEBUG" == "true" ]]; then
echo "#####"
component_list=$(oc get multiclusterobservability --all-namespaces -o json | jq -r '.items[].status.components')
printf "%-30s\t%-10s\t%-30s\t%-30s\n" "COMPONENT" "STATUS" "TYPE" "REASON"
for status_item in $(echo $component_list | jq -r 'keys | .[]'); do
component=$(echo $component_list | jq -r --arg ITEM_NAME "$status_item" '.[$ITEM_NAME]')
component_status="$(echo $component | jq -r '.status')";
type="$(echo $component | jq -r '.type')";
reason="$(echo $component | jq -r '.reason')";
message="$(echo $component | jq -r '.message')";
printf "%-30s\t%-10s\t%-30s\t%-30s\n" "$status_item" "$component_status" "$type" "$reason"
done
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt work for obs so lets remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does observability not have components we can watch be torn down?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not check their schema

acc=0
while [[ $(oc get multiclusterobservability --all-namespaces) && $acc -le $POLL_DURATION_21X ]]; do
curr_status=$(oc get multiclusterobservability --all-namespaces -o json | jq -r '.items[].status.phase') 2> /dev/null
echo "Waited $acc/$POLL_DURATION_21X seconds for MCO to be deleted. Current Status: $curr_status"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indention

@openshift-ci-robot
Copy link

@Kyl-Bempah: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants