Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify placement API and add e2e tests #354

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented Mar 21, 2023

@yanmxa
Copy link
Member Author

yanmxa commented Mar 21, 2023

/hold

Signed-off-by: myan <[email protected]>
@openshift-ci openshift-ci bot removed the approved label Mar 21, 2023
@yanmxa yanmxa changed the title add the local policy with placement api in the e2e tests verify placement API and add e2e tests Mar 21, 2023
@yanmxa
Copy link
Member Author

yanmxa commented Mar 21, 2023

/unhold

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yanmxa
Copy link
Member Author

yanmxa commented Mar 22, 2023

/cc @morvencao @clyang82

Copy link
Contributor

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: morvencao, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c0addea into stolostron:main Mar 22, 2023
@yanmxa yanmxa deleted the br_placement branch March 22, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants