Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.redhat.com/browse/ACM-17958 #7519

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

jc-berger
Copy link
Collaborator

No description provided.

@jc-berger jc-berger requested a review from rhaignere February 19, 2025 17:17
@jc-berger jc-berger self-assigned this Feb 19, 2025
Copy link
Collaborator

@rhaignere rhaignere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks!


* Delivers updates to one or more product container images.

* Detects if the `MultiClusterHub` made any changes that need to be applied to the container images. (link:https://issues.redhat.com/browse/ACM-16518[ACM-16518])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are saying here that the "Errata 2.11.6" "detects" if the mch made any changes.

I don't think we mean that subject/verb agreement--something is missing here.

(Also, Errata does not (or should not) deliver new features, but I may have missed a special case?)

@coleenquadros
Copy link

The bug 16518 resolves unnecessary reconciles on the MCO operator when there are changes/updates made to the MCH CR. When there is an update to the MCH CR, Observability is only concerned with the Image Manifest Configmap changes that will apply to the components Observability deploys.

@openshift-ci openshift-ci bot added the lgtm label Feb 25, 2025
Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, rhaignere, swopebe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Feb 26, 2025
Copy link

openshift-ci bot commented Feb 26, 2025

New changes are detected. LGTM label has been removed.

@jc-berger jc-berger merged commit ba4c683 into 2.11_stage Feb 26, 2025
1 check failed
@jc-berger jc-berger deleted the jcberger-17958-acm-errata branch February 26, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants