feat(rulesets): validate channel servers, server securities and operation securities #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
enhancement
magicmatatjahu
requested review from
smoya,
jonaslagoni and
a team
as code owners
9 tasks
jonaslagoni
reviewed
Apr 12, 2022
magicmatatjahu
force-pushed
the
asyncapi/channel-servers
branch
from
b2fa1a4
to
aead22f
Compare
magicmatatjahu
changed the title
magicmatatjahu
changed the title
magicmatatjahu
changed the title
magicmatatjahu
changed the title
magicmatatjahu
changed the title
magicmatatjahu
changed the title
magicmatatjahu
force-pushed
the
asyncapi/channel-servers
branch
from
b57929e
to
906b987
Compare
|
@jonaslagoni Could you check that PR? Thanks! |
smoya
reviewed
Jun 27, 2022
| function asyncApi2ChannelServers(targetVal, _) { | ||
| const results: IFunctionResult[] = []; | ||
| if (!targetVal.channels) return results; | ||
| const serverNames = Object.keys(targetVal.servers ?? {}); |
There was a problem hiding this comment.
What if there are no servers declared but the channels declares a value under servers channel field?
There was a problem hiding this comment.
|
@P0lip Hello! @jonaslagoni just accepted that PR. I guess we need your accept, because I changed also docs. Thanks! |
stoplight-bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
# [@stoplight/spectral-rulesets-v1.11.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.10.0...@stoplight/spectral-rulesets-v1.11.0) (2022-06-30) ### Features * **rulesets:** validate channel servers, server securities and operation securities ([#2122](#2122)) ([9accd31](9accd31))
|
🎉 This PR is included in version @stoplight/spectral-rulesets-v1.11.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2124
Fixes #2123
Fixes #2162
Checklist
Does this PR introduce a breaking change?
Additional context
Part of #2100
This PR adds three rules:
serversexist (we compare names inserverswith those defined inchannels.*.servers).servers.*.securityexist incomponents.securitySchemes.channels.*.[publish,subscribe].securityexist incomponents.securitySchemes.