-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rulesets): add AsyncAPI v3 support #2697
feat(rulesets): add AsyncAPI v3 support #2697
Conversation
9590abc
to
ef5a264
Compare
6f55c0b
to
e19da87
Compare
The last CircleCI test are simply timing out, no idea how to fix that. All ready to be reviewed. |
5c95cb1
to
b87d147
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Some minor remarks:
- Formats Package:
- Bump package version to
1.8.0
- Update deps in consuming packages: functions, ruleset-bundler, rulesets, and core (devDependencies)
- Bump package version to
- Rulesets Package:
- Bump package version to
1.21.0
- Bump package version to
@frankkilcommins are those not automatically bumped on release? 🤔 |
Alright, updated dependencies, but I am getting some weird dependency problems in code I have not touched... Any suggestions? |
Oh maybe - I've not seen the release job but I manually bumped when adding Arazzo core rulesets. @mnaumanali94 can you confirm. |
@frankkilcommins semantic-release does bump it automatically if the commit messages are done right. |
So I guess I revert the manual version bumping? 🤔 Anything else that needs to happen? |
@jonaslagoni I have fixed the CI - There are some conflicts in docs, so if you can fix those and merge the develop branch, the checks should pass.
Yes that should be it. |
All good, looking at it tomorrow most likely ✌️ |
All ready ✌️ @mnaumanali94 @frankkilcommins |
thanks @frankkilcommins |
@msolujic we hope to include in the next release. We should get that out the door over the next week or so. |
Hi, Do you have ETA to release this feature? Thanks, |
Fixes #2559.
Checklist
Does this PR introduce a breaking change?
Additional context
Does not update the following rules:
Limits to rules: