Added support for PV grow #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japokorn
force-pushed
the
3.9-devel-sr_pv_resize_support
branch
3 times, most recently
from
f9eb277 to
835c49a
Compare
|
| @@ -107,6 +110,17 @@ def __repr__(self): | |||
| "pe_start": self.pe_start, "data_alignment": self.data_alignment}) | |||
| return s | |||
|
|
|||
| @property | |||
| def grow_to_fill(self): | |||
There was a problem hiding this comment.
Please add a docstring here explaining how this works, e.g. what target size needs to be set to make this work and that ActionResizeFormat still needs to be created and executed.
There was a problem hiding this comment.
Fixed. Added docstring.
Storage role requires support for a case when PV has to be resized to fill all available space when its device's size changes (usually on VM). A new flag 'grow_to_fill' was added, which marks the device for size expansion (all available space it taken). Proper size is determined by LVM, avoiding inaccurate size calculations in blivet.
japokorn
force-pushed
the
3.9-devel-sr_pv_resize_support
branch
from
835c49a to
9290cdf
Compare
vojtechtrefny
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage role requires support for a case when PV has to be resized to fill all available space when its device's size changes (usually on VM).
A new flag
grow_to_fillwas added, which marks the device for size expansion (all available space it taken).Proper size is determined by LVM, avoiding inaccurate size calculations in blivet.