uplink-sys(fix): Make build copying more resilient #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifraixedes
requested changes
Nov 11, 2024
This fixes an issue where: 1. User tries to build before initializing all submodules. 2. `uplink-c` directory is empty and copied into build. 3. Build fails but leaves empty `uplink-c` directory in build directory 4. User initializes `uplink-c` and then tries to build again without cleaning. 5. `uplink-c` gets nested in a second level deeper, causing build issues.
GodTamIt
changed the title
ifraixedes
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where:
uplink-cdirectory is empty and copied into build.uplink-cdirectory in build directoryuplink-cand then tries to build again without cleaning.uplink-cgets nested in a second level deeper, causing build issues.