Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user cmd #123

Merged
merged 9 commits into from
Oct 29, 2024
Merged

feat: user cmd #123

merged 9 commits into from
Oct 29, 2024

Conversation

alvarosabu
Copy link
Contributor

Hi, this is the new implementation of the user commands for the renovated version of the CLI. Is a followup from #118

Please make sure to check the previous PR before this one.

How to test this PR

  • Clone the repo and pull the branch
  • pnpm install
  • pnpm run build:stub <-- Important you test it with stub for now

Once build without issues

  • Use pnpm run dev user

Unit test

There are 2 Test files related to this command

You can run the tests:

pnpm run test

And coverage

pnpm run coverage

Testing checklist

I'm including the same manual testing checklist I used during TDD

User

storyblok-cli user

  • If user is logged should prompt a message like this
Screenshot 2024-10-07 at 12 45 57 - [ ] If user is not logged in should return `You are not logged in. Please login first`

@alvarosabu alvarosabu added the p3-significant [Priority] Moderate issues, major enhancements label Oct 7, 2024
@alvarosabu alvarosabu self-assigned this Oct 7, 2024
@alvarosabu alvarosabu changed the base branch from master to next October 7, 2024 10:48
src/commands/user/index.ts Outdated Show resolved Hide resolved
@alvarosabu alvarosabu merged commit 044ff92 into next Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant [Priority] Moderate issues, major enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants