Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-structured language command with sub commands #148

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

alvarosabu
Copy link
Contributor

@alvarosabu alvarosabu commented Jan 16, 2025

  • Changed command name from pull-languages to languages across the codebase for consistency and add sub command 'pull'
  • Updated resolved path to .storyblok/languages/spaceId/filename.suffix.json by default
  • Updated launch configuration to reflect the new command name.
  • Introduced new actions and constants for managing languages, including fetching and saving language data.
  • Added tests for the new languages command and its actions.
  • Removed obsolete pull-languages command and its associated tests.

Previously:

storyblok pull-languages -s <spaceId>

Saves to .storyblok/languages/languages.spaceId.json

Current

storyblok languages pull -s <spaceId>

Saves to .storyblok/languages/spaceId/languages.json

- Changed command name from `pull-languages` to `languages` across the codebase for consistency and add sub command 'pull'
- Updated resolved path to `.storyblok/languages/spaceId/filename.suffix.json` by default
- Updated launch configuration to reflect the new command name.
- Introduced new actions and constants for managing languages, including fetching and saving language data.
- Added tests for the new languages command and its actions.
- Removed obsolete `pull-languages` command and its associated tests.
@alvarosabu alvarosabu requested a review from edodusi January 16, 2025 08:14
@alvarosabu alvarosabu self-assigned this Jan 16, 2025
@alvarosabu alvarosabu added the p3-significant [Priority] Moderate issues, major enhancements label Jan 16, 2025
Copy link
Contributor

@edodusi edodusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick suggestion, for the rest LGTM!

src/commands/languages/index.ts Show resolved Hide resolved
- Introduced an alias 'lang' for the 'languages' command to enhance usability and streamline command input.
@alvarosabu alvarosabu merged commit e48e870 into next Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant [Priority] Moderate issues, major enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants