Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CLI error message now gives more info about the error #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gbyesiltas
Copy link

PR type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

How to test this PR

  1. Trigger a cli command that will trigger an error
  2. You should see the error message instead of Error [object Object]

What is the new behavior?

  • e.message now takes precedence over the whole of the error object
  • The error object is now stringified instead of showing Error [object Object]

Other information

I recently ran the pull-components command and received this error message and I thought we could improve the Error: [object Object] part:

- Executing pull-components task
X An error ocurred in pull-components task when load components data
X An error occurred when executing the pull-components task: Error: [object Object]

I don't have a very broad understanding of the repo so please feel free to ask for a modification or do the necessary modifications if needed :)

@gbyesiltas gbyesiltas changed the title CLI error now stringifies the error object feat: CLI error now gives more info about an error May 30, 2024
@gbyesiltas gbyesiltas changed the title feat: CLI error now gives more info about an error feat: CLI error message now gives more info about an error May 30, 2024
@gbyesiltas gbyesiltas changed the title feat: CLI error message now gives more info about an error feat: CLI error message now gives more info about the error May 30, 2024
@MauroPello
Copy link

I ran into the same issue! Would be nice to get it fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants