fix(v7)!: check transactions succeed after they're included in a block #1087
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Yea this is an SDK thing. It always returns code 0 so long as it passes message Validate(), but then once included is when the real failure can occur (like gas, etc) I do worry that some users may want a tx which is successful on submit but fail upstream (I have this exact case checked with proof of authority). I need to think on this more |
|
hmm, i think we should maybe introduce different error types then; that way you get an |
Reecepbcups
changed the title
|
Thinking about it, I think it makes sense to for ExecTx. If someone wants to bypass they can use |
Reecepbcups
changed the title
|
@fastfadingviolets This will need the latest v7 branch merged in on your side, then it will be good to go (does not seem I have maintainer edit perms to this PR) Ill also port to v8 / main as well |
Head branch was pushed to by a user without write access
fastfadingviolets
force-pushed
the
fix/v7-query-tx
branch
from
dda5d50
to
8ef62a9
Compare
|
Ty! |
…ey're included in a block (#1095) * Fix v7: check transactions succeed after they're included in a block (#1087) (cherry picked from commit a3d5c18) # Conflicts: # examples/cosmos/chain_miscellaneous_test.go * merge conflicts (incoming) --------- Co-authored-by: violet <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]>
Summary
Sometimes a transaction returns code 0 initially, but then fails when a validator goes to actually include it in a block. This PR adds code to cosmos' ExecTx to make sure transactions are verified after their inclusion in a block; if they fail at any stage of proceedings, an error is returned.