feat: local chain registry endpoint #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jtieri
approved these changes
Aug 20, 2024
Comment on lines
+47
to
+62
| chainRegistryFile := filepath.Join(wd, "chain_registry.json") | ||
| if _, err := os.Stat(chainRegistryFile); err == nil { | ||
| crH := handlers.NewChainRegistry(chainRegistryFile) | ||
| r.HandleFunc("/chain_registry", crH.GetChainRegistry).Methods(http.MethodGet) | ||
| } else { | ||
| log.Printf("chain_registry.json not found in %s, not exposing endpoint.", wd) | ||
| } | ||
|
|
||
| chainRegistryAssetsFile := filepath.Join(wd, "chain_registry_assets.json") | ||
| if _, err := os.Stat(chainRegistryAssetsFile); err == nil { | ||
| crH := handlers.NewChainRegistry(chainRegistryAssetsFile) | ||
| r.HandleFunc("/chain_registry_assets", crH.GetChainRegistry).Methods(http.MethodGet) | ||
| } else { | ||
| log.Printf("chain_registry_assets.json not found in %s, not exposing endpoint.", wd) | ||
| } | ||
|
|
There was a problem hiding this comment.
we call the same handler here so is it just handling the case where the file could be named either chain_registry.json or chain_registry_assets? is there any reason for this explicit handling of both?
There was a problem hiding this comment.
it uses the same as it just returns the JSON object. Since its specific to chain registry and only do that 1 function, it makes sense to just re-use it vs duplicate code.
If we need to add extra logic in the future I would rather keep it scoped to chain registry then a generic JSON viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: rollchains/spawn#194
Summary
if the chain_registry.json file is found when running
local-ic start <name>, it will showcase this in an easy to query way. This makes it easy to connect wallets and build existing infra on top. Better UX