-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(local-ic): bash driver #1207
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Looks good. One thing that I would add in the future would be some help message if a bash function is called with the wrong number of arguments - but that depends on feedback from users. The scripts are easy to understand and anyone who has knowledge of cosmos should not have an issue with reading them. |
local-interchain/bash/source.bash
Outdated
ICT_ADD_FULL_NODE() { | ||
API=$1 | ||
CHAIN_ID=$2 | ||
AMOUNT=$3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider using local
local API=$1, CHAIN_ID=$2, AMOUNT=$3
in this way variables will not leak into outside context which might make debugging harder especially if multiple functions are called in succession with different args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved in: 92e712f
ref #795
Summary
Basic external bash driver which can be imported to interact with local-ic. Why? it's easier sometimes and I find myself wanting a helper constantly.