Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add new CI jobs and bring existing ones into compliance #1233

Merged
merged 16 commits into from
Sep 29, 2024
Merged

Conversation

jtieri
Copy link
Member

@jtieri jtieri commented Aug 23, 2024

This PR revises the existing CI jobs to be conformant with our OSS guidelines.

All repo settings should also be in compliance with the OSS template now, EXCEPT for the required status checks. It seems like the GitHub workflow files need to me merged before it allows you to update the settings to use them.

The changes also include linter fixes that were able to be applied via golangci-lint run ./... --fix

Edit: we decided to stick with the existing workflow for releases due to issues we were having with the cross-arch compilation of local-ic. We have decided that since interchaintest is a library and that we are only building the binary for local-ic it does not make sense to try and force a pattern that doesn't translate well.

@jtieri jtieri requested a review from a team as a code owner August 23, 2024 16:05
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 4:28pm

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

# Conflicts:
#	chain/ethereum/ethererum_chain.go
#	chain/ethereum/foundry/forge.go
#	examples/ethereum/foundry_test.go
#	examples/thorchain/chainspec_thorchain.go
#	examples/thorchain/helper.go
#	examples/thorchain/setup.go
Update the goreleaser CI action to be compliant with our OSS template
Updates the goreleaser config file to correctly build the local-ic binaries
@jtieri jtieri changed the title DNM: ci: add new CI jobs and bring existing ones into compliance ci: add new CI jobs and bring existing ones into compliance Sep 13, 2024
.golangci.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@Reecepbcups
Copy link
Member

todo: remove goreleaser

@jtieri jtieri enabled auto-merge (squash) September 18, 2024 14:36
@jtieri jtieri merged commit 9ac38cc into main Sep 29, 2024
18 of 19 checks passed
@jtieri jtieri deleted the justin/ci branch September 29, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants