feat!: local-ic remove relayer file dependency #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
changed the title
jtieri
approved these changes
Dec 14, 2023
|
let's see, the python modifications may have resolved it edit: add I had a hard check in the local-ic binary for it due to old relayer, will remove that to be good |
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Remove `relayer.json` in favor of CLI arguments * py: make nested directories for config * git keep `configs` * exist_ok=True * remove .gitkeep * remove forced `config` directory check (cherry picked from commit b85a060)
Reecepbcups
added a commit
that referenced
this pull request
Dec 14, 2023
* Remove `relayer.json` in favor of CLI arguments * py: make nested directories for config * git keep `configs` * exist_ok=True * remove .gitkeep * remove forced `config` directory check (cherry picked from commit b85a060) Co-authored-by: Reece Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #795
Previously it was required for developers to maintain a relayer.json file with the image information. For most use cases this is excessive as the defaults work. Instead it should be a startup option to override default relayer image information.
If none are specific, the latest cosmos relayer image is used.
Only a breaking change if a team uses a custom relayer image for local-ic