-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #63 and other minor changes #64
base: develop
Are you sure you want to change the base?
Conversation
```docker-compose.yml``` need to be copied from the example compose file before running ```docker compose up```
There is no description on the PR. If you want the PR to be considered, please follow the guidelines here: https://github.com/stratosphereips/AIVPN/blob/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md |
Updating the codeql versions to @V3
Updated the description. Apologies for not including a proper description. |
Thanks. Another thing, please review our contributing guidelines, you always need to PR to development, not to main. Please change it and make sure the changes are still valid given there were some changes already that I think may overlap. |
I will remove the build script PR as you have already resolved it in the |
I have changed the branch. Can you check it? |
Fix build script, update deployment documentation and correct the wrong subnet in deployment file
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #63
There is an error while running
build.sh
. Using the correct package manager solves it which is what I did in this PR.I have also updated
deployment.rst
file which specifies that the user has to copy the example docker-compose and rename it asdocker-compose.yml
. After which, the user would be able to run the command to start deployment.The last change is in the
docker-compose.yml
file where the subnet is wrong. It should be172.16.1.0
instead of172.16.1.1
.What is the new behavior?