Add JDC/S initializers in integration tests #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher Report
|
| Branch | 1226/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,515.00 | 📈 view plot | 3,772.00 | 📈 view plot | 5,295.00 | 📈 view plot | 7.00 | 📈 view plot | 91.00 |
| get_submit | 📈 view plot | 95,430.00 | 📈 view plot | 59,522.00 | 📈 view plot | 85,510.00 | 📈 view plot | 45.00 | 📈 view plot | 277.00 |
| get_subscribe | 📈 view plot | 8,034.00 | 📈 view plot | 2,848.00 | 📈 view plot | 3,984.00 | 📈 view plot | 12.00 | 📈 view plot | 114.00 |
| serialize_authorize | 📈 view plot | 12,298.00 | 📈 view plot | 5,343.00 | 📈 view plot | 7,458.00 | 📈 view plot | 9.00 | 📈 view plot | 137.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,897.00 | 📈 view plot | 9,920.00 | 📈 view plot | 14,017.00 | 📈 view plot | 34.00 | 📈 view plot | 306.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,435.00 | 📈 view plot | 12,097.00 | 📈 view plot | 17,140.00 | 📈 view plot | 55.00 | 📈 view plot | 372.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,589.00 | 📈 view plot | 73,363.00 | 📈 view plot | 105,189.00 | 📈 view plot | 115.00 | 📈 view plot | 595.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 28,017.00 | 📈 view plot | 9,666.00 | 📈 view plot | 13,677.00 | 📈 view plot | 61.00 | 📈 view plot | 401.00 |
| serialize_deserialize_submit | 📈 view plot | 115,479.00 | 📈 view plot | 68,223.00 | 📈 view plot | 97,934.00 | 📈 view plot | 65.00 | 📈 view plot | 492.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,439.00 | 📈 view plot | 8,225.00 | 📈 view plot | 11,589.00 | 📈 view plot | 39.00 | 📈 view plot | 333.00 |
| serialize_submit | 📈 view plot | 99,827.00 | 📈 view plot | 61,566.00 | 📈 view plot | 88,352.00 | 📈 view plot | 48.00 | 📈 view plot | 321.00 |
| serialize_subscribe | 📈 view plot | 11,375.00 | 📈 view plot | 4,195.00 | 📈 view plot | 5,840.00 | 📈 view plot | 15.00 | 📈 view plot | 156.00 |
|
| Branch | 1226/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,087.00 | 📈 view plot | 473.00 | 📈 view plot | 737.00 | 📈 view plot | 4.00 | 📈 view plot | 38.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,204.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,159.00 | 📈 view plot | 36.00 | 📈 view plot | 139.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,289.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,549.00 | 📈 view plot | 20.00 | 📈 view plot | 104.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,640.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,760.00 | 📈 view plot | 43.00 | 📈 view plot | 219.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,472.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,402.00 | 📈 view plot | 83.00 | 📈 view plot | 333.00 |
| client_sv2_open_channel | 📈 view plot | 4,387.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,157.00 | 📈 view plot | 12.00 | 📈 view plot | 62.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,936.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,331.00 | 📈 view plot | 33.00 | 📈 view plot | 184.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,707.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,672.00 | 📈 view plot | 79.00 | 📈 view plot | 304.00 |
| client_sv2_setup_connection | 📈 view plot | 4,677.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,277.00 | 📈 view plot | 11.00 | 📈 view plot | 67.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,106.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,666.00 | 📈 view plot | 39.00 | 📈 view plot | 207.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,504.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,819.00 | 📈 view plot | 98.00 | 📈 view plot | 377.00 |
|
| Branch | 1226/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.93 |
| client_sv2_handle_message_mining | 📈 view plot | 73.41 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.65 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 263.69 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 1,012.20 |
| client_sv2_open_channel | 📈 view plot | 147.40 |
| client_sv2_open_channel_serialize | 📈 view plot | 295.29 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 485.48 |
| client_sv2_setup_connection | 📈 view plot | 164.91 |
| client_sv2_setup_connection_serialize | 📈 view plot | 474.25 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 1,092.60 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
=======================================
Coverage 19.30% 19.30%
=======================================
Files 164 164
Lines 10849 10849
=======================================
Hits 2094 2094
Misses 8755 8755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
GitGab19
reviewed
Oct 18, 2024
plebhash
reviewed
Oct 25, 2024
Comment on lines
+286
to
+290
| pub async fn start_jdc( | ||
| pool_address: SocketAddr, | ||
| tp_address: SocketAddr, | ||
| jds_address: SocketAddr, | ||
| ) -> SocketAddr { |
There was a problem hiding this comment.
This is initializing the get_available_address internal and returns it here, which is I think what we want
plebhash
reviewed
Oct 25, 2024
| jdc_address | ||
| } | ||
|
|
||
| pub async fn start_jds(tp_address: SocketAddr) -> SocketAddr { |
There was a problem hiding this comment.
This is initializing the get_available_address internal and returns it here, which is I think what we want
|
I pulled this branch and tried to do some quick experimentation, where my goal was to put a sniffer between JDC and JDS to look into the messages they are exchanging. Here's my test: #[tokio::test]
async fn sniff_jdc_jds() {
let sniffer_addr = common::get_available_address();
let tp_addr = common::get_available_address();
let _jdc_addr = common::get_available_address();
let jds_addr = common::get_available_address();
let pool_addr = common::get_available_address();
let _tp = common::start_template_provider(tp_addr.port()).await;
let _pool = common::start_pool(Some(pool_addr), Some(tp_addr)).await;
let _jds = common::start_jds(tp_addr).await;
let sniffer = common::start_sniffer(sniffer_addr, jds_addr).await;
let _jdc = common::start_jdc(pool_addr, tp_addr, sniffer_addr).await;
let d = sniffer.next_downstream_message();
let u = sniffer.next_upstream_message();
println!("d: {:?}", d);
println!("u: {:?}", u);
}but when I tried to run it, I got a nasty panic... did I make some mistake on the test above, or is there something wrong with the APIs? The log line that really stand out is: which is coming from anyways, here's the full panic logs: |
jbesraa
changed the title
You should use the values returned from |
jbesraa
force-pushed
the
2024-10-18-jds/c-test-starters
branch
from
2d23c27 to
cae7f2d
Compare
|
@plebhash This is ready for review |
|
| Branch | 2024-10-18-jds/c-test-starters |
| Testbed | sv2 |
🚨 2 Alerts
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| client_sv2_mining_message_submit_standard_serialize_deserialize | Estimated Cycles estimated cycles | 📈 plot 🚨 alert (🔔) 🚷 threshold | 27,848.00 (+1.16%) | 27,765.01 (100.30%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | L1 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 15,503.00 (+0.70%) | 15,498.89 (100.03%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2,069.00 (-1.14%) | 2,205.68 (93.80%) | 📈 view plot 🚷 view threshold | 473.00 (-0.05%) | 488.63 (96.80%) | 📈 view plot 🚷 view threshold | 734.00 (-0.24%) | 757.57 (96.89%) | 📈 view plot 🚷 view threshold | 8.00 (+46.29%) | 14.19 (56.37%) | 📈 view plot 🚷 view threshold | 37.00 (-2.61%) | 41.16 (89.89%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8,204.00 (-0.01%) | 8,287.71 (98.99%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.03%) | 2,143.08 (99.72%) | 📈 view plot 🚷 view threshold | 3,159.00 (-0.06%) | 3,170.58 (99.63%) | 📈 view plot 🚷 view threshold | 36.00 (+1.23%) | 42.21 (85.29%) | 📈 view plot 🚷 view threshold | 139.00 (-0.02%) | 140.92 (98.64%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6,289.00 (+0.17%) | 6,388.99 (98.43%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.05%) | 1,767.00 (99.04%) | 📈 view plot 🚷 view threshold | 2,549.00 (-0.18%) | 2,575.88 (98.96%) | 📈 view plot 🚷 view threshold | 20.00 (+17.70%) | 24.66 (81.12%) | 📈 view plot 🚷 view threshold | 104.00 (0.00%) | 107.03 (97.17%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14,804.00 (+0.50%) | 14,963.13 (98.94%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.02%) | 4,711.00 (99.64%) | 📈 view plot 🚷 view threshold | 6,749.00 (-0.14%) | 6,782.46 (99.51%) | 📈 view plot 🚷 view threshold | 50.00 (+14.82%) | 53.59 (93.29%) | 📈 view plot 🚷 view threshold | 223.00 (+0.66%) | 227.64 (97.96%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 27,848.00 (+1.16%) | 27,765.01 (100.30%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.61%) | 10,645.64 (99.99%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 15,503.00 (+0.70%) | 15,498.89 (100.03%) | 📈 view plot 🚷 view threshold | 89.00 (+9.31%) | 90.20 (98.67%) | 📈 view plot 🚷 view threshold | 340.00 (+1.48%) | 341.43 (99.58%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4,375.00 (-0.48%) | 4,608.72 (94.93%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.02%) | 1,476.63 (98.94%) | 📈 view plot 🚷 view threshold | 2,160.00 (+0.01%) | 2,184.93 (98.86%) | 📈 view plot 🚷 view threshold | 9.00 (+0.61%) | 17.58 (51.19%) | 📈 view plot 🚷 view threshold | 62.00 (-1.00%) | 68.30 (90.78%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14,012.00 (-0.33%) | 14,439.89 (97.04%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.01%) | 5,079.63 (99.69%) | 📈 view plot 🚷 view threshold | 7,327.00 (+0.02%) | 7,352.63 (99.65%) | 📈 view plot 🚷 view threshold | 35.00 (-0.31%) | 43.30 (80.83%) | 📈 view plot 🚷 view threshold | 186.00 (-0.72%) | 198.32 (93.79%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22,820.00 (+0.70%) | 22,901.09 (99.65%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.25%) | 8,074.46 (99.57%) | 📈 view plot 🚷 view threshold | 11,690.00 (+0.20%) | 11,754.29 (99.45%) | 📈 view plot 🚷 view threshold | 84.00 (+12.89%) | 85.38 (98.39%) | 📈 view plot 🚷 view threshold | 306.00 (+0.82%) | 311.54 (98.22%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4,647.00 (-0.79%) | 4,772.48 (97.37%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.02%) | 1,517.63 (98.97%) | 📈 view plot 🚷 view threshold | 2,277.00 (-0.07%) | 2,299.33 (99.03%) | 📈 view plot 🚷 view threshold | 12.00 (+28.00%) | 15.93 (75.34%) | 📈 view plot 🚷 view threshold | 66.00 (-2.05%) | 69.82 (94.53%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16,156.00 (-0.10%) | 16,461.72 (98.14%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.00%) | 5,978.63 (99.74%) | 📈 view plot 🚷 view threshold | 8,661.00 (-0.03%) | 8,692.24 (99.64%) | 📈 view plot 🚷 view threshold | 43.00 (+7.58%) | 53.43 (80.48%) | 📈 view plot 🚷 view threshold | 208.00 (-0.39%) | 216.37 (96.13%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35,688.00 (+0.39%) | 35,747.58 (99.83%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.27%) | 14,907.31 (99.87%) | 📈 view plot 🚷 view threshold | 21,883.00 (+0.32%) | 21,919.60 (99.83%) | 📈 view plot 🚷 view threshold | 94.00 (+1.36%) | 113.77 (82.62%) | 📈 view plot 🚷 view threshold | 381.00 (+0.46%) | 384.61 (99.06%) |
|
| Branch | 2024-10-18-jds/c-test-starters |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8,379.00 (-0.90%) | 8,831.84 (94.87%) | 📈 view plot 🚷 view threshold | 3,689.00 (-1.54%) | 3,893.99 (94.74%) | 📈 view plot 🚷 view threshold | 5,159.00 (-1.81%) | 5,465.35 (94.39%) | 📈 view plot 🚷 view threshold | 7.00 (-2.61%) | 12.98 (53.92%) | 📈 view plot 🚷 view threshold | 91.00 (+0.63%) | 96.20 (94.60%) |
| get_submit | 📈 view plot 🚷 view threshold | 95,407.00 (-0.01%) | 95,989.23 (99.39%) | 📈 view plot 🚷 view threshold | 59,346.00 (-0.19%) | 59,712.58 (99.39%) | 📈 view plot 🚷 view threshold | 85,222.00 (-0.21%) | 85,785.58 (99.34%) | 📈 view plot 🚷 view threshold | 42.00 (-6.65%) | 64.00 (65.63%) | 📈 view plot 🚷 view threshold | 285.00 (+1.84%) | 289.41 (98.48%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7,872.00 (-1.75%) | 8,389.82 (93.83%) | 📈 view plot 🚷 view threshold | 2,765.00 (-2.39%) | 2,973.72 (92.98%) | 📈 view plot 🚷 view threshold | 3,847.00 (-2.84%) | 4,158.25 (92.51%) | 📈 view plot 🚷 view threshold | 14.00 (+16.59%) | 20.81 (67.29%) | 📈 view plot 🚷 view threshold | 113.00 (-0.95%) | 120.16 (94.04%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12,210.00 (-0.51%) | 12,656.09 (96.48%) | 📈 view plot 🚷 view threshold | 5,266.00 (-0.98%) | 5,463.60 (96.38%) | 📈 view plot 🚷 view threshold | 7,325.00 (-1.23%) | 7,626.41 (96.05%) | 📈 view plot 🚷 view threshold | 11.00 (+20.86%) | 15.95 (68.95%) | 📈 view plot 🚷 view threshold | 138.00 (+0.40%) | 143.65 (96.07%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24,340.00 (-1.38%) | 25,285.49 (96.26%) | 📈 view plot 🚷 view threshold | 9,838.00 (-0.52%) | 10,058.43 (97.81%) | 📈 view plot 🚷 view threshold | 13,890.00 (-0.51%) | 14,215.84 (97.71%) | 📈 view plot 🚷 view threshold | 32.00 (-7.98%) | 44.38 (72.10%) | 📈 view plot 🚷 view threshold | 294.00 (-2.43%) | 315.70 (93.13%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30,068.00 (-0.82%) | 30,792.22 (97.65%) | 📈 view plot 🚷 view threshold | 12,015.00 (-0.54%) | 12,228.94 (98.25%) | 📈 view plot 🚷 view threshold | 17,003.00 (-0.61%) | 17,325.06 (98.14%) | 📈 view plot 🚷 view threshold | 58.00 (+4.05%) | 68.32 (84.89%) | 📈 view plot 🚷 view threshold | 365.00 (-1.21%) | 381.81 (95.60%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126,369.00 (-0.07%) | 127,084.23 (99.44%) | 📈 view plot 🚷 view threshold | 73,200.00 (-0.11%) | 73,598.29 (99.46%) | 📈 view plot 🚷 view threshold | 104,914.00 (-0.13%) | 105,548.02 (99.40%) | 📈 view plot 🚷 view threshold | 105.00 (-1.95%) | 133.33 (78.75%) | 📈 view plot 🚷 view threshold | 598.00 (+0.30%) | 605.55 (98.75%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27,468.00 (-1.29%) | 28,648.15 (95.88%) | 📈 view plot 🚷 view threshold | 9,584.00 (-0.65%) | 9,792.35 (97.87%) | 📈 view plot 🚷 view threshold | 13,543.00 (-0.74%) | 13,854.84 (97.75%) | 📈 view plot 🚷 view threshold | 69.00 (+8.66%) | 76.13 (90.64%) | 📈 view plot 🚷 view threshold | 388.00 (-2.05%) | 417.17 (93.01%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115,117.00 (-0.09%) | 115,931.39 (99.30%) | 📈 view plot 🚷 view threshold | 68,060.00 (-0.06%) | 68,438.01 (99.45%) | 📈 view plot 🚷 view threshold | 97,657.00 (-0.07%) | 98,268.99 (99.38%) | 📈 view plot 🚷 view threshold | 62.00 (-1.16%) | 78.26 (79.22%) | 📈 view plot 🚷 view threshold | 490.00 (-0.20%) | 499.68 (98.06%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 22,842.00 (-1.73%) | 24,074.08 (94.88%) | 📈 view plot 🚷 view threshold | 8,143.00 (-0.71%) | 8,348.97 (97.53%) | 📈 view plot 🚷 view threshold | 11,467.00 (-0.74%) | 11,761.97 (97.49%) | 📈 view plot 🚷 view threshold | 35.00 (-6.18%) | 44.67 (78.35%) | 📈 view plot 🚷 view threshold | 320.00 (-2.65%) | 348.95 (91.70%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99,796.00 (-0.04%) | 100,388.36 (99.41%) | 📈 view plot 🚷 view threshold | 61,408.00 (-0.15%) | 61,751.00 (99.44%) | 📈 view plot 🚷 view threshold | 88,081.00 (-0.19%) | 88,624.36 (99.39%) | 📈 view plot 🚷 view threshold | 47.00 (+0.33%) | 64.70 (72.64%) | 📈 view plot 🚷 view threshold | 328.00 (+1.08%) | 334.07 (98.18%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11,317.00 (-0.68%) | 11,770.28 (96.15%) | 📈 view plot 🚷 view threshold | 4,118.00 (-1.49%) | 4,319.19 (95.34%) | 📈 view plot 🚷 view threshold | 5,707.00 (-1.88%) | 6,013.38 (94.91%) | 📈 view plot 🚷 view threshold | 16.00 (+24.50%) | 20.67 (77.40%) | 📈 view plot 🚷 view threshold | 158.00 (+0.30%) | 164.16 (96.25%) |
|
| Branch | 2024-10-18-jds/c-test-starters |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 45.05 (+0.86%) | 47.60 (94.66%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 72.83 (-3.26%) | 86.47 (84.23%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 14.66 (-0.03%) | 14.71 (99.61%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 274.38 (+2.42%) | 320.01 (85.74%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 636.91 (+5.97%) | 743.20 (85.70%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 147.45 (-0.09%) | 157.93 (93.36%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 283.17 (-0.59%) | 318.22 (88.99%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 409.36 (+7.62%) | 454.42 (90.08%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 161.93 (+0.29%) | 176.71 (91.64%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 470.63 (+0.92%) | 574.70 (81.89%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 994.46 (+2.23%) | 1,078.62 (92.20%) |
|
| Branch | 2024-10-18-jds/c-test-starters |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,793.50 (+1.06%) | 7,137.49 (95.18%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,773.80 (+1.56%) | 8,065.93 (96.38%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 8,284.10 (+0.97%) | 8,643.82 (95.84%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 895.32 (+2.35%) | 952.59 (93.99%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 696.97 (+3.25%) | 746.95 (93.31%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 244.20 (-1.72%) | 265.15 (92.10%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 155.83 (-1.02%) | 165.15 (94.35%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,608.80 (+1.40%) | 7,249.72 (91.16%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 286.37 (+2.67%) | 304.84 (93.94%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 736.76 (+0.45%) | 800.33 (92.06%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 600.95 (+0.61%) | 629.94 (95.40%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 205.83 (-0.68%) | 226.24 (90.98%) |
|
aha! finally got this to work: #[tokio::test]
async fn sniff_jdc_jds() {
let sniffer_addr = common::get_available_address();
let tp_addr = common::get_available_address();
let pool_addr = common::get_available_address();
let _tp = common::start_template_provider(tp_addr.port()).await;
let _pool = common::start_pool(Some(pool_addr), Some(tp_addr)).await;
let jds_addr = common::start_jds(tp_addr).await;
let sniffer = common::start_sniffer(sniffer_addr, jds_addr).await;
let _jdc_addr = common::start_jdc(pool_addr, tp_addr, sniffer_addr).await;
let d = sniffer.next_downstream_message();
let u = sniffer.next_upstream_message();
println!("d: {:?}", d);
println!("u: {:?}", u);
let d = sniffer.next_downstream_message();
let u = sniffer.next_upstream_message();
println!("d: {:?}", d);
println!("u: {:?}", u);
let d = sniffer.next_downstream_message();
let u = sniffer.next_upstream_message();
println!("d: {:?}", d);
println!("u: {:?}", u);
} |
|
@jbesraa one comment based on your answer:
this is still related to #1234, more specifically on fragmentation of return types if the starters only return I'll approve the PR and let @jbesraa decide if we fix it on this PR or on a separate one, but in case we don't do it here it's important not to forget about these details and tackle them sooner rather than later |
plebhash
approved these changes
Nov 18, 2024
pavlenex
force-pushed
the
2024-10-18-jds/c-test-starters
branch
from
cae7f2d to
ee69573
Compare
I believe this is just to have convenient input parameters for btw this struct has a bad name, it's probably copypasta from some old proxy implementation, but this should be called not sure we want to fix that on this PR, but worth point out anyways |
Yea I think for now returning the listening address seems kinda ok. With the |
Yea this one is extremely annoying but I didn't wanna start changing the roles at this points.. I do think we should do it sooner than later though. Tracked here #1260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1223