Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove async-std from mining-device-sv1 #1423

Conversation

Shourya742
Copy link
Contributor

partially closes: #1402

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.04%. Comparing base (933495b) to head (1a5d9c8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
+ Coverage   17.97%   24.04%   +6.07%     
==========================================
  Files         167      112      -55     
  Lines       11925     7942    -3983     
==========================================
- Hits         2143     1910     -233     
+ Misses       9782     6032    -3750     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.40% <ø> (ø)
binary_sv2-coverage 5.11% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.12% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.27% <ø> (ø)
jd_client-coverage ?
jd_server-coverage ?
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.34% <ø> (ø)
mining_device-coverage ?
mining_proxy_sv2-coverage ?
noise_sv2-coverage 4.25% <ø> (ø)
pool_sv2-coverage ?
protocols 23.86% <ø> (ø)
roles ?
roles_logic_sv2-coverage 8.70% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage ?
utils 25.13% <ø> (ø)
v1-coverage 2.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@plebhash plebhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@plebhash plebhash added ready-to-be-merged triggers auto rebase bot refactor Implies refactoring code roles Pertains to all roles cpu miner roles-utils Utility logic for roles labels Feb 1, 2025
@pavlenex pavlenex force-pushed the 2025-01-30-remove-async-std-support-from_mining-device-sv1 branch 3 times, most recently from f36a9aa to f414ad9 Compare February 1, 2025 03:28
@Shourya742 Shourya742 force-pushed the 2025-01-30-remove-async-std-support-from_mining-device-sv1 branch from f414ad9 to 1a5d9c8 Compare February 1, 2025 03:32
@plebhash plebhash merged commit 2763ece into stratum-mining:main Feb 1, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpu miner ready-to-be-merged triggers auto rebase bot refactor Implies refactoring code roles Pertains to all roles roles-utils Utility logic for roles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove async_std support
3 participants