-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update dependencies #1524
Conversation
…e stratum-common Updates this util to use just the bitcoin crate defined in stratum-common in accordance with stratum-mining#1487
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1524 +/- ##
==========================================
+ Coverage 17.87% 19.09% +1.21%
==========================================
Files 132 131 -1
Lines 10069 9433 -636
==========================================
+ Hits 1800 1801 +1
+ Misses 8269 7632 -637
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one small nit.
Here is the original issue btw #1500
CI seem to be unhappy because |
Co-authored-by: jbesraa <[email protected]>
commit history is getting a bit dirty here
also, clippy CI is broken while fixing it, please avoid adding yet a new commit like the |
maybe wait until #1492 is merged (in a few minutes) before fixing clippy CI |
I'll fix and squash once CI is happy. |
Closed in favor of #1528 |
and refactor bip32 key derivation to use stratum-common.
Updates this util to use just the bitcoin crate defined in stratum-common in accordance with #1487