Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update dependencies #1524

Closed

Conversation

average-gary
Copy link
Contributor

and refactor bip32 key derivation to use stratum-common.

Updates this util to use just the bitcoin crate defined in stratum-common in accordance with #1487

…e stratum-common

Updates this util to use just the bitcoin crate defined in stratum-common in accordance with stratum-mining#1487
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 19.09%. Comparing base (a32c988) to head (2e474a0).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
utils/bip32-key-derivation/src/main.rs 0.00% 4 Missing ⚠️
utils/bip32-key-derivation/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
+ Coverage   17.87%   19.09%   +1.21%     
==========================================
  Files         132      131       -1     
  Lines       10069     9433     -636     
==========================================
+ Hits         1800     1801       +1     
+ Misses       8269     7632     -637     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 8.59% <ø> (+1.63%) ⬆️
bip32_derivation-coverage 0.00% <0.00%> (ø)
buffer_sv2-coverage 37.68% <ø> (ø)
codec_sv2-coverage 0.03% <ø> (+<0.01%) ⬆️
common_messages_sv2-coverage 0.21% <ø> (+0.03%) ⬆️
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.45% <ø> (+0.08%) ⬆️
jd_client-coverage 0.44% <ø> (+0.02%) ⬆️
jd_server-coverage 14.56% <ø> (+1.49%) ⬆️
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 3.61% <ø> (ø)
mining-coverage 3.89% <ø> (+0.73%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.96% <ø> (+0.13%) ⬆️
noise_sv2-coverage 7.30% <ø> (+1.51%) ⬆️
pool_sv2-coverage 2.76% <ø> (+0.29%) ⬆️
protocols 27.15% <ø> (+3.26%) ⬆️
roles 7.01% <ø> (+0.04%) ⬆️
roles_logic_sv2-coverage 13.54% <ø> (+1.95%) ⬆️
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.96% <ø> (+0.37%) ⬆️
utils 36.39% <0.00%> (ø)
v1-coverage 3.74% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small nit.
Here is the original issue btw #1500

@jbesraa
Copy link
Contributor

jbesraa commented Mar 5, 2025

CI seem to be unhappy because version was updated in Cargo.lock. You can either change it manually back to '3' or use rust 1.75 when changing the deps

@average-gary
Copy link
Contributor Author

LGTM. Just one small nit. Here is the original issue btw #1500

Thnx. Fixed the nit, and good catch.
Closes #1500

@plebhash
Copy link
Collaborator

plebhash commented Mar 5, 2025

commit history is getting a bit dirty here

  • refactor: cargo fmt commit should be squashed to the first commit
  • we usually rebase against main instead of adding merge commits

also, clippy CI is broken

while fixing it, please avoid adding yet a new commit like the cargo fmt

@plebhash
Copy link
Collaborator

plebhash commented Mar 5, 2025

maybe wait until #1492 is merged (in a few minutes) before fixing clippy CI

@average-gary
Copy link
Contributor Author

commit history is getting a bit dirty here

  • refactor: cargo fmt commit should be squashed to the first commit
  • we usually rebase against main instead of adding merge commits

also, clippy CI is broken

while fixing it, please avoid adding yet a new commit like the cargo fmt

I'll fix and squash once CI is happy.

@average-gary
Copy link
Contributor Author

Closed in favor of #1528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants