Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return null on empty files/images #466

Merged
merged 1 commit into from
Jan 27, 2024
Merged

fix: Return null on empty files/images #466

merged 1 commit into from
Jan 27, 2024

Conversation

bellini666
Copy link
Member

Fix #453

@bellini666 bellini666 self-assigned this Jan 27, 2024
@bellini666 bellini666 requested a review from patrick91 January 27, 2024 15:34
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e751a2d) 87.86% compared to head (9f46e8c) 87.86%.

Files Patch % Lines
strawberry_django/resolvers.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files          37       37           
  Lines        3148     3157    +9     
=======================================
+ Hits         2766     2774    +8     
- Misses        382      383    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bellini666 bellini666 merged commit 35a85e7 into main Jan 27, 2024
56 checks passed
@bellini666 bellini666 deleted the fix_null_file branch January 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It returns an null error for a nullable ImageField () field.
3 participants