-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix specialized connection aliases missing filters/ordering #547
Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue where specialized connection aliases were missing filters and ordering arguments. The changes ensure that when retrieving the strawberry Django type, any File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 5 issues found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bellini666 Awesome! This really helps me with my migration. 🙏 👏 |
When retrieving the strawberry django type, we need to make sure to resolve any
LazyType
and also to consider specialized type vars for aliases to get theNodeType
from them.This also bumps the minimum strawberry version to 0.234.2 as the fix in that release is required for this change.
Without this change,
Author.books
would not containfilters
andorder
argumentsFix #535
Thanks @Eraldo for reporting and creating an MRE that helped to identify the issue
Summary by Sourcery
This pull request fixes a bug where specialized connection aliases were missing filters and ordering arguments by resolving LazyType and considering specialized type vars for aliases. New tests were added to ensure the correctness of these changes.