-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix optimized nested connections failing to access totalCount #553
Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue with nested MPTT (Modified Preorder Tree Traversal) connections when trying to access the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 88.67% 88.71% +0.03%
==========================================
Files 41 41
Lines 3524 3527 +3
==========================================
+ Hits 3125 3129 +4
+ Misses 399 398 -1 ☔ View full report in Codecov by Sentry. |
When resolving the connection from cache, we were missing setting
nodes
in it 🤦♂️We do have a test that was passing with this, but MPTT triggered the issue. The issue was probably happening to corner cases as well
Used #551 as a base for the reproduction, but adjusted it to avoid depending on python 3.9
Fix #552